-
-
Notifications
You must be signed in to change notification settings - Fork 140
feat: dynamically register jni methods and use @FastNative & @CriticalNative #1792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using the new annotations to improve the runtime for our jni calls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if these should be FastNative. FastNative completely disables GC while it's running, and these could likely run for a good while.
callJSMethodNative is even trickier because we can go java->native->java->native multiple times in long running methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the fastest we can go for those would be !
More info on
@FastNative&@CriticalNativecan be found here https://developer.android.com/training/articles/perf-jni#faster-native-calls-with-fastnative-and-criticalnative