Commit 01e5313

committed

Add not integer support amount to Money VO

1 parent 6e82aa1 commit 01e5313Copy full SHA for 01e5313

File tree

2 files changed

+16

-8

lines changed

src/Money
- Money.php
tests/Money
- MoneyTest.php

2 files changed

+16

-8

lines changed

`‎src/Money/Money.php‎`

Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -19,9 +19,9 @@ class Money`
`19`	`19`	`/**`
`20`	`20`	`* Amount`
`21`	`21`	`*`
`22`		`- * @var int`
	`22`	`+ * @var float`
`23`	`23`	`*/`
`24`		`- private int $amount;`
	`24`	`+ private float $amount;`
`25`	`25`	`/**`
`26`	`26`	`* Currency`
`27`	`27`	`*`
`@@ -30,10 +30,10 @@ class Money`
`30`	`30`	`private Currency $currency;`
`31`	`31`
`32`	`32`	`/**`
`33`		`- * @param int $amount`
	`33`	`+ * @param float $amount`
`34`	`34`	`* @param Currency $currency`
`35`	`35`	`*/`
`36`		`- public function __construct(int $amount, Currency $currency)`
	`36`	`+ public function __construct(float $amount, Currency $currency)`
`37`	`37`	`{`
`38`	`38`	`$this->amount = $amount;`
`39`	`39`	`$this->currency = $currency;`
`@@ -43,20 +43,20 @@ public function __construct(int $amount, Currency $currency)`
`43`	`43`	`* Add an integer quantity to the amount and returns a new Money object.`
`44`	`44`	`* Use a negative quantity for subtraction.`
`45`	`45`	`*`
`46`		`- * @param int $quantity quantity to add`
	`46`	`+ * @param float $quantity quantity to add`
`47`	`47`	`*`
`48`	`48`	`* @return Money`
`49`	`49`	`*/`
`50`		`- public function add(int $quantity): Money`
	`50`	`+ public function add(float $quantity): Money`
`51`	`51`	`{`
`52`	`52`	`$amount = $this->getAmount() + $quantity;`
`53`	`53`	`return new static($amount, $this->getCurrency());`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`/**`
`57`		`- * @return int`
	`57`	`+ * @return float`
`58`	`58`	`*/`
`59`		`- public function getAmount(): int`
	`59`	`+ public function getAmount(): float`
`60`	`60`	`{`
`61`	`61`	`return $this->amount;`
`62`	`62`	`}`

`‎tests/Money/MoneyTest.php‎`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,14 @@ public function testSuccess(): void`
`22`	`22`	`self::assertEquals($currency, $money->getCurrency());`
`23`	`23`	`}`
`24`	`24`
	`25`	`+ public function testNotInteger(): void`
	`26`	`+ {`
	`27`	`+ $money = new Money($amount = 100.66, $currency = $this->createCurrency());`
	`28`	`+`
	`29`	`+ self::assertEquals($amount, $money->getAmount());`
	`30`	`+ self::assertEquals($currency, $money->getCurrency());`
	`31`	`+ }`
	`32`	`+`
`25`	`33`	`public function testToString(): void`
`26`	`34`	`{`
`27`	`35`	`$money = new Money($amount = 100, $currency = $this->createCurrency());`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 01e5313

File tree

2 files changed

2 files changed

`‎src/Money/Money.php‎`

`‎tests/Money/MoneyTest.php‎`

0 commit comments