Commit 11d34b8

MihaiCristianCondrea MihaiCristianCondrea

authored

Merge pull request #135 from MihaiCristianCondrea/codex/update-native-ad-banners-design

Refine home screen native ads

2 parents 97ed26a + bc79534 commit 11d34b8Copy full SHA for 11d34b8

File tree

4 files changed

-94

lines changed

app/src/main
- java/com/d4rk/androidtutorials/java/ui/screens/home
  - HomeFragment.java
- res/layout

4 files changed

-94

lines changed

`‎app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/home/HomeFragment.java‎`

Lines changed: 0 additions & 21 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,6 @@`
`11`	`11`	`import androidx.lifecycle.ViewModelProvider;`
`12`	`12`
`13`	`13`	`import com.d4rk.androidtutorials.java.databinding.FragmentHomeBinding;`
`14`		`-import com.d4rk.androidtutorials.java.ads.managers.NativeAdLoader;`
`15`	`14`	`import com.google.android.gms.ads.AdRequest;`
`16`	`15`	`import com.google.android.gms.ads.MobileAds;`
`17`	`16`
`@@ -54,11 +53,7 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat`
`54`	`53`	`promotedContainer.clearFocus();`
`55`	`54`	`promotedContainer.removeAllViews();`
`56`	`55`	`java.util.List<PromotedApp> apps = state.promotedApps();`
`57`		`- int adPosition = new java.util.Random().nextInt(apps.size() + 1);`
`58`	`56`	`for (int i = 0; i < apps.size(); i++) {`
`59`		`- if (i == adPosition) {`
`60`		`- addPromotedAd(promotedContainer);`
`61`		`- }`
`62`	`57`	`PromotedApp app = apps.get(i);`
`63`	`58`	`com.d4rk.androidtutorials.java.databinding.PromotedAppItemBinding itemBinding =`
`64`	`59`	`com.d4rk.androidtutorials.java.databinding.PromotedAppItemBinding.inflate(inflater, promotedContainer, false);`
`@@ -69,9 +64,6 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat`
`69`	`64`	`itemBinding.shareButton.setOnClickListener(v -> shareApp(app));`
`70`	`65`	`promotedContainer.addView(itemBinding.getRoot());`
`71`	`66`	`}`
`72`		`- if (adPosition == apps.size()) {`
`73`		`- addPromotedAd(promotedContainer);`
`74`		`- }`
`75`	`67`	`});`
`76`	`68`	`new FastScrollerBuilder(binding.scrollView)`
`77`	`69`	`.useMd2Style()`
`@@ -120,17 +112,4 @@ private void loadImage(String url, android.widget.ImageView imageView) {`
`120`	`112`	`.centerInside()`
`121`	`113`	`.into(imageView);`
`122`	`114`	`}`
`123`		`-`
`124`		`- private void addPromotedAd(ViewGroup container) {`
`125`		`- android.widget.FrameLayout adContainer = new android.widget.FrameLayout(requireContext());`
`126`		`- ViewGroup.MarginLayoutParams params = new ViewGroup.MarginLayoutParams(dpToPx(160), dpToPx(180));`
`127`		`- params.setMarginEnd(dpToPx(8));`
`128`		`- adContainer.setLayoutParams(params);`
`129`		`- NativeAdLoader.load(requireContext(), adContainer, com.d4rk.androidtutorials.java.R.layout.promoted_native_ad);`
`130`		`- container.addView(adContainer);`
`131`		`- }`
`132`		`-`
`133`		`- private int dpToPx(int dp) {`
`134`		`- return Math.round(dp * requireContext().getResources().getDisplayMetrics().density);`
`135`		`- }`
`136`	`115`	`}`

`‎app/src/main/res/layout/fragment_home.xml‎`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -147,6 +147,7 @@`
`147`	`147`	`android:id="@+id/large_banner_ad"`
`148`	`148`	`android:layout_width="match_parent"`
`149`	`149`	`android:layout_height="wrap_content"`
	`150`	`+ android:layout_marginHorizontal="16dp"`
`150`	`151`	`android:layout_marginTop="16dp"`
`151`	`152`	`android:layout_marginBottom="16dp"`
`152`	`153`	`app:nativeAdLayout="@layout/native_ad" />`
`@@ -218,6 +219,7 @@`
`218`	`219`	`android:id="@+id/small_banner_ad"`
`219`	`220`	`android:layout_width="match_parent"`
`220`	`221`	`android:layout_height="wrap_content"`
	`222`	`+ android:layout_marginHorizontal="16dp"`
`221`	`223`	`android:layout_marginTop="16dp"`
`222`	`224`	`app:nativeAdLayout="@layout/native_ad" />`
`223`	`225`

`‎app/src/main/res/layout/native_ad.xml‎`

Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,15 +7,14 @@`
`7`	`7`	`<com.google.android.material.card.MaterialCardView`
`8`	`8`	`android:layout_width="match_parent"`
`9`	`9`	`android:layout_height="wrap_content"`
`10`		`- android:layout_margin="16dp"`
`11`		`- style="@style/Widget.Material3.CardView.Filled"`
	`10`	`+ style="@style/Widget.Material3.CardView.Outlined"`
`12`	`11`	`app:shapeAppearanceOverlay="@style/ShapeAppearanceOverlay.CardView">`
`13`	`12`
`14`	`13`	`<LinearLayout`
`15`	`14`	`android:layout_width="match_parent"`
`16`	`15`	`android:layout_height="wrap_content"`
`17`		`- android:orientation="vertical"`
`18`		`- android:padding="8dp">`
	`16`	`+ android:layout_margin="16dp"`
	`17`	`+ android:orientation="vertical">`
`19`	`18`
`20`	`19`	`<TextView`
`21`	`20`	`android:id="@+id/ad_attribution"`

`‎app/src/main/res/layout/promoted_native_ad.xml‎`

Lines changed: 0 additions & 69 deletions

This file was deleted.

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 11d34b8

File tree

4 files changed

4 files changed

`‎app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/home/HomeFragment.java‎`

`‎app/src/main/res/layout/fragment_home.xml‎`

`‎app/src/main/res/layout/native_ad.xml‎`

`‎app/src/main/res/layout/promoted_native_ad.xml‎`

0 commit comments