-
Notifications
You must be signed in to change notification settings - Fork 34
LBLE library update #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* #89: use `equal_range` when searching for elements in STL multimap, instead of using `find`. `find` is not guaranteed to return the first element in the equal range. * #90: Add a new set of interfaces to `LBLEClient` that allows user to identify a characteristic by using service index and characteristic index, instead of using UUID. Note that it is possible for a device to have multiple characteristics with the same UUID. * #90: Add a new example `EnumerateCharacteristic.ino` that uses the new indices-based interface of `LBLEClient` to list all the services and characteristics in the connected BLE device. * #90: Use `bt_gattc_read_charc` instead of `bt_gattc_read_using_charc_uuid` to read characteristics. * #91: when calling `bt_gattc_discover_charc`, we need to wait for multiple `BT_GATTC_DISCOVER_CHARC` event. We added new helper function `waitAndProcessEventMultiple` that supports such event waiting behavior. * Refactored `LBLEValueBuffer` to support re-interpreting its raw buffer content into String, float, int, and char types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fixes
Unreliable lookup method used within LBLEEventDispatcher class #89 : use
equal_rangewhen searching for elements in STL multimap, instead of usingfind.findis not guaranteed to return the first element in the equal range.Improper characteristic list implementation of LBLEClient class #90 : Add a new set of interfaces to
LBLEClientthat allows user to identify a characteristic by using service index and characteristic index, instead of using UUID. Note that it is possible for a device to have multiple characteristics with the same UUID.Improper characteristic list implementation of LBLEClient class #90 : Add a new example
EnumerateCharacteristic.inothat uses the new indices-based interface ofLBLEClientto list all the services and characteristics in the connected BLE device.Improper characteristic list implementation of LBLEClient class #90 : Use
bt_gattc_read_charcinstead ofbt_gattc_read_using_charc_uuidto read characteristics.Some characteristics are missing if performing characteristic discovery with the LBLEClient class using LBLE library #91 : when calling
bt_gattc_discover_charc, we need to wait for multipleBT_GATTC_DISCOVER_CHARCevent. We added new helper functionwaitAndProcessEventMultiplethat supports such event waiting behavior.Refactored
LBLEValueBufferto support re-interpreting its raw buffer content into String, float, int, and char types.