Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 90f123e

Browse files
fix(fs): Fix fs API error handling
1 parent f4e3909 commit 90f123e

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

‎easy/fs/Directory.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ class Directory extends Document {
128128
*/
129129
delete() {
130130
return new Promise( ( resolve, reject ) => {
131-
fs.rmdir( this.path, error => error ? Promise.reject( error ) : Promise.resolve() )
131+
fs.rmdir( this.path, error => error ? reject( error ) : resolve() )
132132
})
133133
}
134134

@@ -162,7 +162,7 @@ class Directory extends Document {
162162
*/
163163
rename( newName ) {
164164
return new Promise( ( resolve, reject ) => {
165-
fs.rename( this.path, `${dir}/${newName}`, error => error ? Promise.reject( error ) : Promise.resolve() )
165+
fs.rename( this.path, `${dir}/${newName}`, error => error ? reject( error ) : resolve() )
166166

167167
this.loadPathInfo( newPath )
168168
})

‎easy/fs/File.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ class File extends Document {
110110
* @returns {Object}
111111
*/
112112
readSync( options = { encoding: 'utf8' }) {
113-
let results = { success: false, data: null,error: null }
113+
let results = { success: false, data: null }
114114

115115
try {
116116
results.data = fs.readFileSync( this.path, options )
@@ -144,7 +144,7 @@ class File extends Document {
144144
* @returns {Object}
145145
*/
146146
createSync( options = { mode: 755, encoding: 'utf8' }) {
147-
let results = { success: false,error: null }
147+
let results = { success: false }
148148

149149
try {
150150
this.writeSync( options )
@@ -185,7 +185,7 @@ class File extends Document {
185185
* @returns {Object}
186186
*/
187187
writeSync( content = '', options = { mode: 755, encoding: 'utf8' }) {
188-
let results = { success: false,error: null }
188+
let results = { success: false }
189189

190190
try {
191191
if ( content.length > 0 ) {
@@ -214,7 +214,7 @@ class File extends Document {
214214
*/
215215
delete() {
216216
return new Promise( ( resolve, reject ) => {
217-
fs.unlink( this.path, error => error ? Promise.reject( error ) : Promise.resolve() )
217+
fs.unlink( this.path, error => error ? reject( error ) : resolve() )
218218
})
219219
}
220220

@@ -226,7 +226,7 @@ class File extends Document {
226226
* @memberOf File
227227
*/
228228
deleteSync() {
229-
let results = { success: false,error: null }
229+
let results = { success: false }
230230

231231
try {
232232
fs.unlinkSync( this.path )
@@ -250,7 +250,7 @@ class File extends Document {
250250
return new Promise( ( resolve, reject ) => {
251251
const newPath = `${this.directory.path}/${newName}`
252252

253-
fs.rename( this.path, newPath, error => error ? Promise.reject( error ) : Promise.resolve() )
253+
fs.rename( this.path, newPath, error => error ? reject( error ) : resolve() )
254254

255255
this.loadPathInfo( newPath )
256256
})

‎todo.txt‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
----------| NOW |----------
33
-----------------------------
44

5+
- pouvoir rm un dossier non vide
56
- dans l'attribut ems (db manager), il faut mettre juste em en valeur du Map et non em et database (cf. addEntityManager())
67
- refactor Application class
78
- faire les tests du vendor

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /