Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit d51dfd2

Browse files
use ISO 8601 correctly
1 parent d189956 commit d51dfd2

File tree

3 files changed

+16
-2
lines changed

3 files changed

+16
-2
lines changed

‎src/main/java/org/learning/by/example/reactive/microservices/services/SunriseSunsetServiceImpl.java‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@ public class SunriseSunsetServiceImpl implements SunriseSunsetService {
1515
private static final String EQUALS = "=";
1616
private static final String LATITUDE_PARAMETER = "lat" + EQUALS;
1717
private static final String LONGITUDE_PARAMETER = "lng" + EQUALS;
18+
private static final String DATE_PARAMETER = "date" + EQUALS;
19+
private static final String TODAY_DATE = "today";
20+
private static final String FORMATTED_PARAMETER = "formatted" + EQUALS;
21+
private static final String NOT_FORMATTED = "0";
1822
private static final String ERROR_GETTING_DATA = "error getting sunrise and sunset";
1923
private static final String SUNRISE_RESULT_NOT_OK = "sunrise result was not OK";
2024
private static final String STATUS_OK = "OK";
@@ -37,10 +41,15 @@ public Mono<SunriseSunset> fromGeographicCoordinates(Mono<GeographicCoordinates>
3741
}
3842

3943
Mono<String> buildUrl(final Mono<GeographicCoordinates> geographicCoordinatesMono) {
40-
return geographicCoordinatesMono.flatMap(geographicCoordinates -> Mono.just(endPoint.concat(BEGIN_PARAMETERS)
44+
return geographicCoordinatesMono.flatMap(geographicCoordinates -> Mono.just(endPoint
45+
.concat(BEGIN_PARAMETERS)
4146
.concat(LATITUDE_PARAMETER).concat(Double.toString(geographicCoordinates.getLatitude()))
4247
.concat(NEXT_PARAMETER)
4348
.concat(LONGITUDE_PARAMETER).concat(Double.toString(geographicCoordinates.getLongitude()))
49+
.concat(NEXT_PARAMETER)
50+
.concat(DATE_PARAMETER).concat(TODAY_DATE)
51+
.concat(NEXT_PARAMETER)
52+
.concat(FORMATTED_PARAMETER).concat(NOT_FORMATTED)
4453
));
4554
}
4655

‎src/main/resources/public/api.yaml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,5 +74,9 @@ definitions:
7474
properties:
7575
sunrise:
7676
type: "string"
77+
format: "date-time"
78+
description: "ISO 8601 UTC without summer time adjustment"
7779
sunset:
7880
type: "string"
81+
format: "date-time"
82+
description: "ISO 8601 UTC without summer time adjustment"

‎src/test/java/org/learning/by/example/reactive/microservices/services/SunriseSunsetServiceImplTests.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ class SunriseSunsetServiceImplTests {
3333
private static final double GOOGLE_LNG = -122.0856086;
3434
private static final GeographicCoordinates GOOGLE_LOCATION = new GeographicCoordinates(GOOGLE_LAT, GOOGLE_LNG);
3535
private static final Mono<GeographicCoordinates> GOOGLE_LOCATION_MONO = Mono.just(GOOGLE_LOCATION);
36-
private static final String GOOGLE_LOCATION_IN_PARAMS = "?lat=" + Double.toString(GOOGLE_LAT) + "&lng=" + Double.toString(GOOGLE_LNG);
36+
private static final String GOOGLE_LOCATION_IN_PARAMS = "?lat=" + Double.toString(GOOGLE_LAT) +
37+
"&lng=" + Double.toString(GOOGLE_LNG)+"&date=today&formatted=0";
3738

3839
private static final String JSON_OK = "/json/GeoTimesResponse_OK.json";
3940
private static final String JSON_KO = "/json/GeoTimesResponse_KO.json";

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /