Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update maxmind database through Artisan::call('geoip:update') calls not only from CLI #34

hliasa started this conversation in Ideas
Discussion options

Hello and thanks for maintaining this fork!
I've tried to update MaxMind's geoip database through a Artisan::call('geoip:update'); call but it returned the following message: The command "geoip:update" does not exist.

Upon further inspection, in GeoIPServiceProvider.php the following codeblock is responsible:

 if ($this->app->runningInConsole()) {
 $this->registerResources();
 $this->registerGeoIpCommands();
 }

Is there any reason for it to check whether it's running through CLI and only then to register the commands?
I mean wouldn't it be better for the end-user to be able to update the database without resorting to php artisan commands?

You must be logged in to vote

Replies: 0 comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Ideas
Labels
None yet
1 participant

AltStyle によって変換されたページ (->オリジナル) /