Commit f72ee09

committed

comments updated & code logic improvised

ThreadPoolExecutor is replaced with ProcessPoolExecutor to increase execution speed

1 parent 2d59cca commit f72ee09Copy full SHA for f72ee09

File tree

-1

lines changed

c4_troubleshooting_debugging_techniques/m2_slowness/src
- retrieve_images_online.py
- thumbnail_generator.py

-1

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -51,3 +51,7 @@ def main():`
`51`	`51`
`52`	`52`	`if __name__ == "__main__":`
`53`	`53`	`main()`
	`54`	`+`
	`55`	`+`
	`56`	`+# NOTE: The ACCESS_KEY is a placeholder for the actual access key that you need to obtain from Unsplash.`
	`57`	`+# SIDE-NOTE: we can improve the script by adding concurrency to download multiple images simultaneously.`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ def main():`
`49`	`49`
`50`	`50`	`os.makedirs('thumbnails', exist_ok=True) # create the thumbnail directory`
`51`	`51`
`52`		`- executor = futures.ThreadPoolExecutor()`
	`52`	`+ executor = futures.ProcessPoolExecutor() # alternate: ThreadPoolExecutor()`
`53`	`53`	`for root, _, files in os.walk('images'):`
`54`	`54`	`for basename in progress_bar(files):`
`55`	`55`	`if basename.endswith('.jpg'):`
`@@ -64,3 +64,7 @@ def main():`
`64`	`64`
`65`	`65`	`if __name__ == "__main__":`
`66`	`66`	`sys.exit(main())`
	`67`	`+`
	`68`	`+`
	`69`	`+# NOTE: here ProcessPoolExecutor() performs better than ThreadPoolExecutor() because of the GIL in Python.`
	`70`	`+# SIDE-NOTE: GIL might become optional in upcoming Python version (3.13).`

Comments

(0)