Commit 291d972

authored

Support ObjectID in findByFields() (#75)

The `findByFields()` method could not find documents by a given ObjectID because the `stringToId()` function was only being run when querying for a field named `_id`. Since any MongoDB field could in theory contain an ObjectID, this broke queries looking for ObjectIDs in arbitrary fields. To resolve this, remove the condition testing for the field name of `_id` and run `stringToId()` on all values. This will validate whether a given String value is actually in the ObjectID format before proceeding, so it seems safe to apply everywhere. Fixes #65

1 parent b40de70 commit 291d972Copy full SHA for 291d972

File tree

1 file changed

-2

lines changed

src
- cache.js

1 file changed

-2

lines changed

`‎src/cache.js‎`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -69,10 +69,12 @@ export const createCachingMethods = ({ collection, model, cache }) => {`
`69`	`69`	`let newVals = Array.isArray(fields[fieldName])`
`70`	`70`	`? fields[fieldName]`
`71`	`71`	`: [fields[fieldName]]`
`72`		`-if(docFieldName==='_id')newVals=newVals.map(stringToId)`
	`72`	`+`
`73`	`73`	`filter[docFieldName].$in = [`
`74`	`74`	`...filter[docFieldName].$in,`
`75`		`- ...newVals.filter(val => !filter[docFieldName].$in.includes(val))`
	`75`	`+ ...newVals`
	`76`	`+ .map(stringToId)`
	`77`	`+ .filter(val => !filter[docFieldName].$in.includes(val))`
`76`	`78`	`]`
`77`	`79`	`}`
`78`	`80`	`if (existingFieldsFilter) return filterArray`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 291d972

File tree

1 file changed

1 file changed

`‎src/cache.js‎`

0 commit comments