Commit 64ed46c

committed

Simplify initialization logic

1 parent 5d013d6 commit 64ed46cCopy full SHA for 64ed46c

File tree

-7

lines changed

-7

lines changed

Lines changed: 3 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ export function DynamicTabs(props: {`
`87`	`87`	`);`
`88`	`88`	`}, [id, tabs, tabsState]);`
`89`	`89`
`90`		`- // Track is the tab has been touched by the user.`
	`90`	`+ // Track if the tab has been touched by the user.`
`91`	`91`	`const touchedRef = useRef(false);`
`92`	`92`
`93`	`93`	`// To avoid issue with hydration, we only use the state from localStorage`
`@@ -133,13 +133,14 @@ export function DynamicTabs(props: {`
`133`	`133`	`: prev.activeTitles,`
`134`	`134`	`};`
`135`	`135`	`});`
`136`		`- setInitialized(true);`
`137`	`136`	`},`
`138`	`137`	`[router, setTabsState, tabs, id]`
`139`	`138`	`);`
`140`	`139`
`141`	`140`	`// When the hash changes, we try to select the tab containing the targetted element.`
`142`	`141`	`React.useLayoutEffect(() => {`
	`142`	`+ setInitialized(true);`
	`143`	`+`
`143`	`144`	`if (hash) {`
`144`	`145`	`// First check if the hash matches a tab ID.`
`145`	`146`	`const hashIsTab = tabs.some((tab) => tab.id === hash);`
`@@ -160,11 +161,6 @@ export function DynamicTabs(props: {`
`160`	`161`	`}`
`161`	`162`
`162`	`163`	`selectTab(tabPanel.id, false);`
`163`		`- } else {`
`164`		`- const firstTab = tabs[0];`
`165`		`- if (firstTab) {`
`166`		`- selectTab(firstTab.id, false);`
`167`		`- }`
`168`	`164`	`}`
`169`	`165`	`}, [selectTab, tabs, hash]);`
`170`	`166`

Comments

(0)