Commit 622ecbe

authored

Handle broken links in header and footer (#3663)

Co-authored-by: Nicolas Dorseuil <nicolas@gitbook.io>

1 parent fa1382b commit 622ecbeCopy full SHA for 622ecbe

File tree

-9

lines changed

packages/gitbook/src/components
- Footer
  - FooterLinksGroup.tsx
- Header
  - HeaderLink.tsx

-9

lines changed

Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -36,13 +36,9 @@ async function FooterLink(props: { link: CustomizationContentLink; context: GitB`
`36`	`36`	`const { link, context } = props;`
`37`	`37`	`const resolved = await resolveContentRef(link.to, context);`
`38`	`38`
`39`		`- if (!resolved) {`
`40`		`- return null;`
`41`		`- }`
`42`		`-`
`43`	`39`	`return (`
`44`	`40`	`<Link`
`45`		`- href={resolved.href}`
	`41`	`+ href={resolved?.href??'#'}`
`46`	`42`	`className={tcls(`
`47`	`43`	`'font-normal',`
`48`	`44`	`'text-tint',`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ export async function HeaderLink(props: {`
`57`	`57`	`);`
`58`	`58`	`}`
`59`	`59`
`60`		`- if (!target\|\|!link.to) {`
	`60`	`+ if (!link.to) {`
`61`	`61`	`return null;`
`62`	`62`	`}`
`63`	`63`
`@@ -68,7 +68,7 @@ export async function HeaderLink(props: {`
`68`	`68`	`headerPreset={headerPreset}`
`69`	`69`	`title={link.title}`
`70`	`70`	`isDropdown={false}`
`71`		`- href={target.href}`
	`71`	`+ href={target?.href}`
`72`	`72`	`/>`
`73`	`73`	`);`
`74`	`74`	`}`
`@@ -78,7 +78,7 @@ export type HeaderLinkNavItemProps = {`
`78`	`78`	`linkStyle: NonNullable<CustomizationHeaderItem['style']>;`
`79`	`79`	`headerPreset: CustomizationHeaderPreset;`
`80`	`80`	`title: string;`
`81`		`- href: string;`
	`81`	`+ href?: string;`
`82`	`82`	`isDropdown: boolean;`
`83`	`83`	`} & DropdownButtonProps<HTMLElement>;`
`84`	`84`
`@@ -165,7 +165,7 @@ function HeaderItemLink(props: Omit<HeaderLinkNavItemProps, 'linkStyle'>) {`
`165`	`165`	`const { linkTarget, headerPreset, title, isDropdown, href, ...rest } = props;`
`166`	`166`	`return (`
`167`	`167`	`<Link`
`168`		`- href={href}`
	`168`	`+ href={href??'#'}`
`169`	`169`	`className={getHeaderLinkClassName({ headerPreset })}`
`170`	`170`	`insights={{`
`171`	`171`	`type: 'link_click',`

Comments

(0)