This repository was archived by the owner on Feb 21, 2024. It is now read-only.

Commit 3b142af

Adrian WalkerAdrian Walker

Adrian Walker

and

Adrian Walker

authored

CLOUD-1456: SERVERLESS - CREATE DATABASE (#2375)

statement without a units qualifier causes it to be set to 0 Co-authored-by: Adrian Walker <adrian.walker@molecula.comm>

1 parent c619b7d commit 3b142afCopy full SHA for 3b142af

File tree

-1

lines changed

-1

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,10 @@ func (p ExecutionPlanner) compileCreateDatabaseStatement(stmt parser.CreateDat`
`17`	`17`	`databaseName := strings.ToLower(parser.IdentName(stmt.Name))`
`18`	`18`	`failIfExists := !stmt.IfNotExists.IsValid()`
`19`	`19`
`20`		`- units := 0`
	`20`	`+ // By default, a database needs at least 1 unit for simple querying, so by`
	`21`	+ // setting the default to 1, users can simply type `CREATE DATABASE [name]` without
	`22`	+ // needing to append `WITH UNITS 1;`
	`23`	`+ units := 1`
`21`	`24`	`description := ""`
`22`	`25`
`23`	`26`	`// apply database options`

Comments

(0)