This repository was archived by the owner on Jul 5, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
This repository was archived by the owner on Jul 5, 2022. It is now read-only.
166 ASCII Image: charIndex out of bounds for white pixels #3633
Open
Labels
@jogerj
Description
in sketch.js, the charIndex of a pixel is calculated as follows:
const charIndex = floor(map(avg, 0, 255, 0, len));
Instead, it should be
const charIndex = floor(map(avg, 0, 256, 0, len));
because otherwise whites (rgb 255, 255, 255) will be mapped to the exact length of the density string which returns '' (an empty string) instead. This results in tearing on videos. The tricky bit was charAt didn't report any error when accessing out of bound index so it went unnoticed.
Nice tutorial btw