Commit 792d65d

committed

ESTE ES UN STEP TEMPORAL

1 parent e7b9e6c commit 792d65dCopy full SHA for 792d65d

File tree

1 file changed

+17

-21

lines changed

examples/php/php-divergent_change-01_base/src/Controller
- CourseStepsGetController.php

1 file changed

+17

-21

lines changed

`‎examples/php/php-divergent_change-01_base/src/Controller/CourseStepsGetController.php‎`

Lines changed: 17 additions & 21 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,12 +8,13 @@`
`8`	`8`
`9`	`9`	`final class CourseStepsGetController`
`10`	`10`	`{`
`11`		`- const VIDEO_DURATION_PAUSES_MULTIPLIER = 1.1;`
`12`		`- const QUIZ_TIME_PER_QUESTION_MULTIPLIER = 0.5;`
`13`		`- const STEP_TYPE_VIDEO = 'video';`
`14`		`- const STEP_TYPE_QUIZ = 'quiz';`
`15`		`- const VIDEO_POINTS_PER_MINUTE = 100;`
`16`		`- const QUIZ_POINTS_PER_MINUTE = 10;`
	`11`	`+ private const VIDEO_DURATION_PAUSES_MULTIPLIER = 1.1;`
	`12`	`+ private const QUIZ_TIME_PER_QUESTION_MULTIPLIER = 0.5;`
	`13`	`+ private const STEP_TYPE_VIDEO = 'video';`
	`14`	`+ private const STEP_TYPE_QUIZ = 'quiz';`
	`15`	`+ private const VIDEO_POINTS_PER_MINUTE = 100;`
	`16`	`+ private const QUIZ_POINTS_PER_MINUTE = 10;`
	`17`	`+`
`17`	`18`	`private Platform $platform;`
`18`	`19`
`19`	`20`	`public function __construct(Platform $platform)`
`@@ -28,22 +29,15 @@ public function get(string $courseId): string`
`28`	`29`	`return '[]';`
`29`	`30`	`}`
`30`	`31`
`31`		`- $csvLines = explode(PHP_EOL, $csv);`
`32`		`-`
`33`		`- $parsedCsv = $this->parseCsv($csvLines);`
	`32`	`+ $parsedCsv = $this->parseCsv($csv);`
`34`	`33`
`35`	`34`	`$results = '[';`
`36`	`35`
`37`		`- $csvLines = explode(PHP_EOL, $csv);`
`38`		`-`
`39`		`- foreach ($csvLines as $index => $row) {`
`40`		`- $row = str_getcsv($row);`
`41`		`-`
`42`		`- if (empty($csv)) {`
`43`		`- continue;`
`44`		`- }`
`45`		`-`
`46`		`- [$stepId, $type, $quizTotalQuestions, $videoDuration] = $row;`
	`36`	`+ foreach ($parsedCsv as $index => $row) {`
	`37`	`+ $stepId = $row['stepId'];`
	`38`	`+ $type = $row['type'];`
	`39`	`+ $quizTotalQuestions = $row['quizTotalQuestions'];`
	`40`	`+ $videoDuration = $row['videoDuration'];`
`47`	`41`
`48`	`42`	`$stepDurationInMinutes = 0;`
`49`	`43`	`$points = 0;`
`@@ -78,7 +72,7 @@ public function get(string $courseId): string`
`78`	`72`	`JSON_THROW_ON_ERROR`
`79`	`73`	`);`
`80`	`74`
`81`		`- $hasMoreRows = $index !== count($csvLines) - 1;`
	`75`	`+ $hasMoreRows = $index !== count($parsedCsv) - 1;`
`82`	`76`	`if ($hasMoreRows) {`
`83`	`77`	`$results .= ',';`
`84`	`78`	`}`
`@@ -89,8 +83,10 @@ public function get(string $courseId): string`
`89`	`83`	`return $results;`
`90`	`84`	`}`
`91`	`85`
`92`		`- private function parseCsv(array$csvLines): array`
	`86`	`+ private function parseCsv(string$csv): array`
`93`	`87`	`{`
	`88`	`+ $csvLines = explode(PHP_EOL, $csv);`
	`89`	`+`
`94`	`90`	`$parsedCsv = [];`
`95`	`91`	`foreach ($csvLines as $row) {`
`96`	`92`	`$row = str_getcsv($row);`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 792d65d

File tree

1 file changed

1 file changed

`‎examples/php/php-divergent_change-01_base/src/Controller/CourseStepsGetController.php‎`

0 commit comments