Commit 27984b0

committed

[PHP] [StepStrategy] Remove other cases implementations rather than the concrete class one

1 parent 647475d commit 27984b0Copy full SHA for 27984b0

File tree

-45

lines changed

-45

lines changed

Lines changed: 1 addition & 15 deletions

Original file line number	Diff line number	Diff line change
`@@ -15,20 +15,6 @@ public function code(): int`
`15`	`15`
`16`	`16`	`public function stepEstimatedCompletionMinutes(Step $instance): int`
`17`	`17`	`{`
`18`		`- $estimation = 0;`
`19`		`-`
`20`		`- switch ($instance->type->code()) {`
`21`		`- case StepType::VIDEO_STEP_TYPE:`
`22`		`- $estimation = $instance->videoDurationInMinutes;`
`23`		`- break;`
`24`		`- case StepType::QUIZ_STEP_TYPE:`
`25`		`- $estimation = QuizStepType::QUIZ_STEP_QUESTION_DURATION_ESTIMATION_IN_MINUTES * count($instance->quizQuestions);`
`26`		`- break;`
`27`		`- case StepType::EXERCISE_STEP_TYPE:`
`28`		`- $estimation = ExerciseStepType::EXERCISE_STEP_DURATION_ESTIMATION_IN_MINUTES;`
`29`		`- break;`
`30`		`- }`
`31`		`-`
`32`		`- return $estimation;`
	`18`	`+ return self::EXERCISE_STEP_DURATION_ESTIMATION_IN_MINUTES;`
`33`	`19`	`}`
`34`	`20`	`}`

Lines changed: 1 addition & 15 deletions

Original file line number	Diff line number	Diff line change
`@@ -21,20 +21,6 @@ public function code(): int`
`21`	`21`
`22`	`22`	`public function stepEstimatedCompletionMinutes(Step $instance): int`
`23`	`23`	`{`
`24`		`- $estimation = 0;`
`25`		`-`
`26`		`- switch ($instance->type->code()) {`
`27`		`- case StepType::VIDEO_STEP_TYPE:`
`28`		`- $estimation = $instance->videoDurationInMinutes;`
`29`		`- break;`
`30`		`- case StepType::QUIZ_STEP_TYPE:`
`31`		`- $estimation = QuizStepType::QUIZ_STEP_QUESTION_DURATION_ESTIMATION_IN_MINUTES * count($instance->quizQuestions);`
`32`		`- break;`
`33`		`- case StepType::EXERCISE_STEP_TYPE:`
`34`		`- $estimation = ExerciseStepType::EXERCISE_STEP_DURATION_ESTIMATION_IN_MINUTES;`
`35`		`- break;`
`36`		`- }`
`37`		`-`
`38`		`- return $estimation;`
	`24`	`+ return self::QUIZ_STEP_QUESTION_DURATION_ESTIMATION_IN_MINUTES * count($instance->quizQuestions);`
`39`	`25`	`}`
`40`	`26`	`}`

Lines changed: 1 addition & 15 deletions

Original file line number	Diff line number	Diff line change
`@@ -20,20 +20,6 @@ public function code(): int`
`20`	`20`
`21`	`21`	`public function stepEstimatedCompletionMinutes(Step $instance): int`
`22`	`22`	`{`
`23`		`- $estimation = 0;`
`24`		`-`
`25`		`- switch ($instance->type->code()) {`
`26`		`- case StepType::VIDEO_STEP_TYPE:`
`27`		`- $estimation = $instance->videoDurationInMinutes;`
`28`		`- break;`
`29`		`- case StepType::QUIZ_STEP_TYPE:`
`30`		`- $estimation = QuizStepType::QUIZ_STEP_QUESTION_DURATION_ESTIMATION_IN_MINUTES * count($instance->quizQuestions);`
`31`		`- break;`
`32`		`- case StepType::EXERCISE_STEP_TYPE:`
`33`		`- $estimation = ExerciseStepType::EXERCISE_STEP_DURATION_ESTIMATION_IN_MINUTES;`
`34`		`- break;`
`35`		`- }`
`36`		`-`
`37`		`- return $estimation;`
	`23`	`+ return $instance->videoDurationInMinutes;`
`38`	`24`	`}`
`39`	`25`	`}`

Comments

(0)