Commit 542275a

committed

Skip NoClassConstFetchOnFactoriesFunction rule inside test classes

1 parent c0da2f4 commit 542275aCopy full SHA for 542275a

File tree

+44

-0

lines changed

+44

-0

lines changed

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@`
`19`	`19`	`use PHPStan\Reflection\ReflectionProvider;`
`20`	`20`	`use PHPStan\Rules\Rule;`
`21`	`21`	`use PHPStan\Rules\RuleErrorBuilder;`
	`22`	`+use PHPUnit\Framework\TestCase;`
`22`	`23`
`23`	`24`	`/**`
`24`	`25`	`* @implements Rule<Node\Expr\FuncCall>`
`@@ -71,6 +72,14 @@ public function processNode(Node $node, Scope $scope): array`
`71`	`72`	`return [];`
`72`	`73`	`}`
`73`	`74`
	`75`	`+ if ($scope->isInClass()) {`
	`76`	`+ $classRef = $scope->getClassReflection();`
	`77`	`+`
	`78`	`+ if ($this->reflectionProvider->hasClass(TestCase::class) && $classRef->isSubclassOf(TestCase::class)) {`
	`79`	`+ return []; // skip uses in test classes as tests are internal`
	`80`	`+ }`
	`81`	`+ }`
	`82`	`+`
`74`	`83`	`$returnType = $this->factoriesReturnTypeHelper->check($scope->getType($classConstFetch), $function);`
`75`	`84`
`76`	`85`	`if ($returnType->isNull()->yes()) {`

Lines changed: 30 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,30 @@`
	`1`	`+<?php`
	`2`	`+`
	`3`	`+declare(strict_types=1);`
	`4`	`+`
	`5`	`+/**`
	`6`	`+ * This file is part of CodeIgniter 4 framework.`
	`7`	`+ *`
	`8`	`+ * (c) 2023 CodeIgniter Foundation <admin@codeigniter.com>`
	`9`	`+ *`
	`10`	`+ * For the full copyright and license information, please view`
	`11`	`+ * the LICENSE file that was distributed with this source code.`
	`12`	`+ */`
	`13`	`+`
	`14`	`+use Config\Cache;`
	`15`	`+use PHPUnit\Framework\TestCase;`
	`16`	`+`
	`17`	`+use function PHPStan\Testing\assertType;`
	`18`	`+`
	`19`	`+assertType('Config\Cache', config(Cache::class));`
	`20`	`+`
	`21`	`+/**`
	`22`	`+ * @internal`
	`23`	`+ */`
	`24`	`+final class ConfigTest extends TestCase`
	`25`	`+{`
	`26`	`+ public function testConfig(): void`
	`27`	`+ {`
	`28`	`+ self::assertContains('file', config(Cache::class)->validHandlers);`
	`29`	`+ }`
	`30`	`+}`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -42,13 +42,18 @@ public function testRule(): void`
`42`	`42`	`{`
`43`	`43`	`$this->analyse([`
`44`	`44`	`__DIR__ . '/../../Fixtures/Type/config.php',`
	`45`	`+ __DIR__ . '/../../Fixtures/Type/factories-in-tests.php',`
`45`	`46`	`__DIR__ . '/../../Fixtures/Type/model.php',`
`46`	`47`	`], [`
`47`	`48`	`[`
`48`	`49`	`'Call to function config with Config\App::class is discouraged.',`
`49`	`50`	`26,`
`50`	`51`	`'Use config(\'App\') instead to allow overriding.',`
`51`	`52`	`],`
	`53`	`+ [`
	`54`	`+ 'Call to function config with Config\Cache::class is discouraged.',`
	`55`	`+ 19,`
	`56`	`+ 'Use config(\'Cache\') instead to allow overriding.', ],`
`52`	`57`	`[`
`53`	`58`	`'Call to function model with stdClass::class is discouraged.',`
`54`	`59`	`19,`

Comments

(0)