Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Decreased Performance due to 'debug(...)' statements in production #369

Open
@Gi-jutsu

Description

Hi @CacheControl
Hope your doing well 😄
First I'd like to thank you for the work done, this is a really useful package !

I'd like to point out a performance issue we are facing in production, there's a debug statement that is run while the addFact function is executed which cause a 2 seconds delay

 addFact (id, valueOrMethod, options) {
 let factId = id
 let fact
 if (id instanceof Fact) {
 factId = id.id
 fact = id
 } else {
 fact = new Fact(id, valueOrMethod, options)
 }
 debug(`engine::addFact id:${factId}`) // <--- This one
 this.facts.set(factId, fact)
 return this
 }

Here's our CPU Profiling

Screenshot 2024年07月11日 at 11 40 17

Is there a way to disable the debug statements ? Otherwise it could be nice to add an option to disable them
Thanks !

If you would like, I would be glad to open a PR to address the following issue.

Have a nice day 😄

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

        AltStyle によって変換されたページ (->オリジナル) /