-
-
Notifications
You must be signed in to change notification settings - Fork 44
Added a simple way to convert between strings and integer #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
You need to run some fixes first.
- Your Integer to String conversion doesn't seem to work, I get
34instead of"34" - You should use the camel case style to name your variables
age_toStringshould beageToString
length_toIntshould belengthToInt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Change the variable name from modulus to findModulus
Looks great!
Change the variable name frommodulustofindModulus
You haven't made this change @1baga
Looks great!
Change the variable name frommodulustofindModulusYou haven't made this change @1baga
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Thank you.
@all-contributors please add @1baga for code
I've put up a pull request to add @1baga! 🎉
Uh oh!
There was an error while loading. Please reload this page.
Added a simple way to convert an Integer to a string and vice versa. Useful when you are making quick conversions to be put in one line of code. Also added the modulus math operation.
screenshot from 2019年02月09日 21-46-46