Commit f846455

authored

Add support to play filename starting with "file://" (zmxv#528)

* Build library to support file:/ pattern * Revert "Build library to support file:/ pattern" This reverts commit a20701a. * Fix to support path starting with file:/

1 parent 87ae91b commit f846455Copy full SHA for f846455

File tree

2 files changed

+11

-1

lines changed

android/src/main/java/com/zmxv/RNSound
- RNSoundModule.java
sound.js

2 files changed

+11

-1

lines changed

`‎android/src/main/java/com/zmxv/RNSound/RNSoundModule.java‎`

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -192,6 +192,16 @@ protected MediaPlayer createMediaPlayer(final String fileName) {`
`192`	`192`	`}`
`193`	`193`	`}`
`194`	`194`
	`195`	`+ if (fileName.startsWith("file:/")){`
	`196`	`+ try {`
	`197`	`+ mediaPlayer.setDataSource(fileName);`
	`198`	`+ } catch(IOException e) {`
	`199`	`+ Log.e("RNSoundModule", "Exception", e);`
	`200`	`+ return null;`
	`201`	`+ }`
	`202`	`+ return mediaPlayer;`
	`203`	`+ }`
	`204`	`+`
`195`	`205`	`File file = new File(fileName);`
`196`	`206`	`if (file.exists()) {`
`197`	`207`	`mediaPlayer.setAudioStreamType(AudioManager.STREAM_MUSIC);`

`‎sound.js‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ var eventEmitter = new ReactNative.NativeEventEmitter(RNSound);`
`10`	`10`	`var nextKey = 0;`
`11`	`11`
`12`	`12`	`function isRelativePath(path) {`
`13`		`- return !/^(\/\|http(s?)\|asset)/.test(path);`
	`13`	`+ return !/^(\/\|http(s?)\|asset\|file)/.test(path);`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`function calculateRelativeVolume(volume, pan) {`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit f846455

File tree

2 files changed

2 files changed

`‎android/src/main/java/com/zmxv/RNSound/RNSoundModule.java‎`

`‎sound.js‎`

0 commit comments