Commit b52ba14

lubomyrlyubomyr

and

lyubomyr

authored

fixed warnings 'new NativeEventEmitter() was called with a non-null argument without the required addListener and removeListener methods' on react-native 0.65 and android platform (zmxv#740)

Co-authored-by: lyubomyr <lubomyr31@gmailc.om>

1 parent 62c90fb commit b52ba14Copy full SHA for b52ba14

File tree

1 file changed

+12

-2

lines changed

android/src/main/java/com/zmxv/RNSound
- RNSoundModule.java

1 file changed

+12

-2

lines changed

`‎android/src/main/java/com/zmxv/RNSound/RNSoundModule.java‎`

Lines changed: 12 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,7 @@ protected MediaPlayer createMediaPlayer(final String fileName) {`
`204`	`204`	`}`
`205`	`205`	`return mediaPlayer;`
`206`	`206`	`}`
`207`		`-`
	`207`	`+`
`208`	`208`	`return null;`
`209`	`209`	`}`
`210`	`210`
`@@ -320,7 +320,7 @@ public void release(final Double key) {`
`320`	`320`	`}`
`321`	`321`	`}`
`322`	`322`	`}`
`323`		`-`
	`323`	`+`
`324`	`324`	`@Override`
`325`	`325`	`public void onCatalystInstanceDestroy() {`
`326`	`326`	`java.util.Iterator it = this.playerPool.entrySet().iterator();`
`@@ -472,4 +472,14 @@ public Map<String, Object> getConstants() {`
`472`	`472`	`constants.put("IsAndroid", true);`
`473`	`473`	`return constants;`
`474`	`474`	`}`
	`475`	`+`
	`476`	`+ @ReactMethod`
	`477`	`+ public void addListener(String eventName) {`
	`478`	`+ // Keep: Required for RN built in Event Emitter Calls.`
	`479`	`+ }`
	`480`	`+`
	`481`	`+ @ReactMethod`
	`482`	`+ public void removeListeners(Integer count) {`
	`483`	`+ // Keep: Required for RN built in Event Emitter Calls.`
	`484`	`+ }`
`475`	`485`	`}`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit b52ba14

File tree

1 file changed

1 file changed

`‎android/src/main/java/com/zmxv/RNSound/RNSoundModule.java‎`

0 commit comments