-
-
Notifications
You must be signed in to change notification settings - Fork 303
feat(colorscheme): add zenbones colorscheme #1676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review Checklist
Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:
Proper conventional commit scoping:
-
If you are adding a new plugin, the scope would be the name of the category it is being added into. ex.
feat(utility): added noice.nvim plugin -
If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex.
fix(noice-nvim): fix LSP handler error -
Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above
-
READMEis properly formatted and uses fenced in links with<url>unless they are inside a[title](url) -
Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).
-
Proper usage of
optstable rather than setting things up with theconfigfunction. -
Proper usage of
specstable for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).
Thanks @Uzaaft
I pulled in your suggested edits and they look good.
Iβve synced my branch to include them.
Let me know if anything else is needed.
There is one missing thing, which is to configure the vim.g option with astrocore(I think its possible, tbh not 100% sure ,it has been a while since I looked at the docs so I gotta refrsh my memory first).
π Description
Added zenbones colorscheme collection
π Additional Information
In order to prevent further dependencies I set the compatibility mode to 1.