-
Notifications
You must be signed in to change notification settings - Fork 382
improvements to assigning type to redaction search results #1021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kanderson91
wants to merge
1
commit into
ApryseSDK:8.12
from
kanderson91:improvements-to-assigning-search-result-type
Open
improvements to assigning type to redaction search results #1021
kanderson91
wants to merge
1
commit into
ApryseSDK:8.12
from
kanderson91:improvements-to-assigning-search-result-type
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @kanderson91, thanks for taking the time to make this PR! We are reviewing it internally and will let you know once this is completed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The webviewer assigns a type to each redaction search result by iterating through all the patterns and seeing which one matches the result text. I was running into some problems with this so I made the following changes:
-Keep track of which patterns are in the current search so that we only have to iterate through those.
-If the user is doing a search for just one pattern, always assign the type of that pattern to each search result.
-When checking if a pattern matches the search result, use the ambient text instead of just the result string.
That last change is useful when using patterns with lookarounds in them. For example, say the user adds this custom pattern to match any string of digits preceded by "ID:"
(?<=ID:\s)\d+
Then say the page has the text "ID: 123" and so we get a search result with "123". In the current logic, the system will check if (?<=ID:\s)\d+ matches "123" and find that it does not. So I changed it to check if it matches the ambient text "ID: 123".