-
Notifications
You must be signed in to change notification settings - Fork 341
Performance fix: prevent unnecessary re-rendering #878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rustjson
rustjson
changed the title
(削除) fix performance issue: prevent unnecessary re-rendering (削除ここまで)
(追記) Performance fix: prevent unnecessary re-rendering (追記ここまで)
Jul 13, 2022
@Akryum Could you please take a look and follow up on this? We are kinda depending on this now.
Thank you so much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
We are having an issue with unnecessary re-rendering for every user input on our tiptap rich-text-editor.
The typing is super laggy and unresponsive when there are many tooltips on the same page.
Because ALL tooltips are re-rendered on every update/keypress.
I have a tests page:
Performance, which contains one rich-text-editor and 1000 tooltips, simplychange this line
https://github.com/Akryum/floating-vue/compare/vue2...rustjson:floating-vue:vue2?diff=split#diff-57103f054b23f6ac8c4a70f7b1ac4d9219b5c2693a75a05903b3967f9d57c6aaR132
to the old version:
update: bindto reproduce the problemSome additional information from vue2's document:
https://v2.vuejs.org/v2/guide/custom-directive.html#Hook-Functions