Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Performance fix: prevent unnecessary re-rendering #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rustjson wants to merge 2 commits into Akryum:vue2
base: vue2
Choose a base branch
Loading
from rustjson:vue2

Conversation

@rustjson
Copy link

@rustjson rustjson commented Jul 13, 2022
edited
Loading

We are having an issue with unnecessary re-rendering for every user input on our tiptap rich-text-editor.

The typing is super laggy and unresponsive when there are many tooltips on the same page.
Because ALL tooltips are re-rendered on every update/keypress.

I have a tests page: Performance, which contains one rich-text-editor and 1000 tooltips, simply

change this line
https://github.com/Akryum/floating-vue/compare/vue2...rustjson:floating-vue:vue2?diff=split#diff-57103f054b23f6ac8c4a70f7b1ac4d9219b5c2693a75a05903b3967f9d57c6aaR132

to the old version: update: bind to reproduce the problem

Some additional information from vue2's document:

https://v2.vuejs.org/v2/guide/custom-directive.html#Hook-Functions

update: called after the containing component’s VNode has updated, but possibly before its children have updated. The directive’s value may or may not have changed, but you can skip unnecessary updates by comparing the binding’s current and old values (see below on hook arguments).

JanKalkan and azamat-h reacted with thumbs up emoji
@rustjson rustjson changed the title (削除) fix performance issue: prevent unnecessary re-rendering (削除ここまで) (追記) Performance fix: prevent unnecessary re-rendering (追記ここまで) Jul 13, 2022
Copy link
Author

@Akryum Could you please take a look and follow up on this? We are kinda depending on this now.

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /