> From: Michael Chan <michael.chan at broadcom.com> > Sent: Wednesday, March 27, 2024 10:39 AM > To: Jakub Kicinski <kuba at kernel.org> > Cc: Ratheesh Kannoth <rkannoth at marvell.com>; Nikita Kiryushin > <kiryushin at ancud.ru>; Michael Chan <mchan at broadcom.com>; Pavan > Chebbi <pavan.chebbi at broadcom.com>; David S. Miller > <davem at davemloft.net>; Eric Dumazet <edumazet at google.com>; Paolo > Abeni <pabeni at redhat.com>; Rafael J. Wysocki <rjw at rjwysocki.net>; > netdev at vger.kernel.org; linux-kernel at vger.kernel.org; lvc- > project at linuxtesting.org > Subject: [EXTERNAL] Re: [PATCH net-next v2] tg3: Remove residual error > handling in tg3_suspend >> Prioritize security for external emails: Confirm sender and content safety > before clicking links or opening attachments >> ---------------------------------------------------------------------- > On Tue, Mar 26, 2024 at 8:24 PM Jakub Kicinski <kuba at kernel.org> wrote: > > > > On 2024年3月27日 08:14:30 +0530 Ratheesh Kannoth wrote: > > > > @@ -18090,7 +18090,6 @@ static int tg3_suspend(struct device > *device) > > > > { > > > Please address Michael Chan's comment to make this function return type > to "void" > > > instead of "int" > > > > It's used as a callback in SIMPLE_DEV_PM_OPS(), how would that work? >> It won't work. I only requested to change tg3_power_down_prepare() to > void and it was done in v2: >> https://lore.kernel.org/netdev/CACKFLinzJjqe0j4OFkcCV+FyH0JiUpnj3j2azZk > GaC9jfvFXrQ at mail.gmail.com/ Got it. Thanks.