[ldv-project] [PATCH v2] can: j1939: Replace WARN_ON_ONCE with netdev_warn_once() in j1939_sk_queue_activate_next_locked()

Mon Aug 8 11:06:32 MSK 2022

On 29.07.2022 17:36:55, Fedor Pchelkin wrote:
> We should warn user-space that it is doing something wrong when trying to
> activate sessions with identical parameters but WARN_ON_ONCE macro can not
> be used here as it serves a different purpose.
>> So it would be good to replace it with netdev_warn_once() message.
>> Found by Linux Verification Center (linuxtesting.org) with Syzkaller.
>> Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
> Signed-off-by: Fedor Pchelkin <pchelkin at ispras.ru>
> Signed-off-by: Alexey Khoroshilov <khoroshilov at ispras.ru>
> Acked-by: Oleksij Rempel <o.rempel at pengutronix.de>

Nitpick: You should add your S-o-b below every other tag line.
Added to linux-can with fixed indention.
Marc
-- 
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://linuxtesting.org/pipermail/ldv-project/attachments/20220808/fe9e9c7c/attachment.pgp>