[ldv-project] [BUG] act_ife: sleeping functions called in atomic context

Fri Jun 17 14:05:20 MSK 2016

On 17.06.2016 08:38, Cong Wang wrote:
> On Thu, Jun 16, 2016 at 7:14 PM, Cong Wang <xiyou.wangcong at gmail.com> wrote:
>>>> I think we can just remove that tcf_lock, I am testing a patch now.
>> Please try the attached patch, I will do more tests tomorrow.
>> Thanks!
>
Looks good with two notes:
1. add_metainfo() still contains
ret = ops->alloc(mi, metaval);
that allocates memory with GFP_KERNEL.
So, I would add gfpflag argument to alloc() operation.
2. It makes sense to mention ife_mod_lock in the comment before
add_metainfo(), because ife_mod_lock is the reason to use GFP_ATOMIC there.
--
Alexey