Please consider this patch as Ack-by: Sathya Prakash Veerichetty<sathya.prakash at broadcom.com> PS: We don't have test environment to test this patch as this is for an old controller. So ACKing based on code review and similar mpt3sas driver code. -----Original Message----- From: Martin K. Petersen [mailto:martin.petersen at oracle.com] Sent: Wednesday, April 27, 2016 7:18 PM To: Alexey Khoroshilov Cc: Sreekanth Reddy; Sathya Prakash; Chaitra P B; Suganath Prabu Subramani; MPT-FusionLinux.pdl at broadcom.com; linux-scsi at vger.kernel.org; linux-kernel at vger.kernel.org; ldv-project at linuxtesting.org Subject: Re: [PATCH] mptsas: fix checks for dma mapping errors >>>>> "Alexey" == Alexey Khoroshilov <khoroshilov at ispras.ru> writes: Alexey> mptsas_smp_handler() checks for dma mapping errors by comparison Alexey> returned address with zero, while pci_dma_mapping_error() should Alexey> be used. Broadcom folks, please review! -- Martin K. Petersen Oracle Linux Engineering