Side navigation
#474 closed bug (fixed)
Opened December 07, 2006 05:21PM UTC
Closed December 11, 2006 09:00AM UTC
Last modified June 20, 2007 02:14AM UTC
oneclick with return false doesn't return false svn $Rev: 670 $
| Reported by: | jakecigar@gmail.com | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | core | Version: | |
| Keywords: | click callback svn | Cc: | jörn |
| Blocked by: | Blocking: |
Description
I use oneclick() on an a and inside the callback I return false, to not execute the a.
when I upgraded to the latest svn version... it seems not to be returning my false, the a is invoked and I leave my page.
it worked on $Rev: 415 $ (and still does work with 415)
the callback code was pared down to an alert and a return false, it still doesn't work.
Attachments (0)
Change History (3)
Changed December 08, 2006 06:38AM UTC by jakecigar@gm comment:1
bug found at line 1551 of event.js
f.apply(this, arguments);
should be
return f.apply(this, arguments);
Please verify and commit.
THANKS
Changed December 10, 2006 06:00AM UTC by jakecigar@gm comment:2
not sure that is enough... I've stopped using oneclick. I liked the old code better!
Changed December 11, 2006 09:00AM UTC by joern comment:3
| resolution: | → fixed |
|---|---|
| status: | new → closed |
Fixed in SVN, adding the return statement fixed the problem.