> On Jul 7, 2025, at 9:15 PM, Damien Le Moal <dlemoal@xxxxxxxxxx> wrote: > > On 7/7/25 9:20 PM, Jonathan Velez wrote: >> sprintf, snprintf, and scnprintf do not consider the PAGE_SIZE maximum >> of the temporary buffer used for outputting sysfs content and they may >> overrun the PAGE_SIZE buffer length. >> >> To avoid output defects with the ATA transport class simple attributes, >> scnprintf() was converted to sysfs_emit(). This aligns with the sysfs >> guidance provided in Documentation/filesystems/sysfs.rst. > > Nit: please use assertive style (no past tense/passive form) > > To avoid output defects with the ATA transport class simple attributes, > use sysfs_emit instead of scnprintf(). I will amend the commit message and submit V2 of the patch. > >> >> Signed-off-by: Jonathan Velez <jonvelez12345@xxxxxxxxx> > > Otherwise, looks good. > > Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx> Thank you, I’m considering reviewing the rest of the libata-transport.c module for similar updates. Thoughts? > -- > Damien Le Moal > Western Digital Research