Re: [PATCH v2 3/4] ata: libata-eh: Rename and make ata_set_mode() static

(追記) (追記ここまで)

• To: Damien Le Moal <dlemoal@xxxxxxxxxx>
• Subject: Re: [PATCH v2 3/4] ata: libata-eh: Rename and make ata_set_mode() static
• From: Niklas Cassel <cassel@xxxxxxxxxx>
• Date: Thu, 3 Jul 2025 12:48:47 +0200
• Cc: linux-ide@xxxxxxxxxxxxxxx
• In-reply-to: <20250703103622.291272-4-dlemoal@kernel.org>
• References: <20250703103622.291272-1-dlemoal@kernel.org> <20250703103622.291272-4-dlemoal@kernel.org>

On Thu, Jul 03, 2025 at 07:36:21PM +0900, Damien Le Moal wrote:
> The function ata_set_mode() is defined and used only in libata-eh.c.
> Make this function static and rename it ata_eh_set_mode() to make it
> clear where its definition is.
>
> No functional changes.
>
> Signed-off-by: Damien Le Moal <dlemoal@xxxxxxxxxx>
Reviewed-by: Niklas Cassel <cassel@xxxxxxxxxx>

• References:
  • [PATCH v2 0/4] Improve log directory handling and some cleanups
    • From: Damien Le Moal
  • [PATCH v2 3/4] ata: libata-eh: Rename and make ata_set_mode() static
    • From: Damien Le Moal

• Prev by Date: Re: [PATCH v2 4/4] ata: libata-core: Rename ata_do_set_mode()
• Next by Date: Re: [PATCH v2 0/4] Improve log directory handling and some cleanups
• Previous by thread: [PATCH v2 3/4] ata: libata-eh: Rename and make ata_set_mode() static
• Next by thread: [PATCH v2 4/4] ata: libata-core: Rename ata_do_set_mode()
• Index(es):
  • Date
  • Thread