* H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> On April 2, 2025 8:41:07 AM PDT, Dave Hansen <dave.hansen@xxxxxxxxx> wrote:
> >On 3/31/25 22:53, Xin Li wrote:
> >> Per "struct msr" defined in arch/x86/include/asm/shared/msr.h:
> >>
> >> struct msr {
> >> union {
> >> struct {
> >> u32 l;
> >> u32 h;
> >> };
> >> u64 q;
> >> };
> >> };
> >>
> >> Probably *msrq() is what we want?
> >
> > What would folks think about "wrmsr64()"? It's writing a 64-bit
> > value to an MSR and there are a lot of functions in the kernel that
> > are named with the argument width in bits.
>
> Personally, I hate the extra verbosity, mostly visual, since numerals
> are nearly as prominent as capital letters they tend to attract the
> eye. There is a reason why they aren't used this way in assembly
> languages.
So what's the consensus here? Both work for me, but I have to pick one. :-)
Thanks,
Ingo