Re: [PATCH] [ARM] pata_pxa: Fix null-ptr-deref in pxa_ata

Re: [PATCH] [ARM] pata_pxa: Fix null-ptr-deref in pxa_ata_probe()

Date Prev

Date Next

Thread Prev

Thread Next

Date Index

Thread Index

(追記) (追記ここまで)

To: Henry Martin <bsdhenrymartin@xxxxxxxxx>, linux-ide@xxxxxxxxxxxxxxx

Subject: Re: [PATCH] [ARM] pata_pxa: Fix null-ptr-deref in pxa_ata_probe()

From: Markus Elfring <Markus.Elfring@xxxxxx>

Date: Thu, 3 Apr 2025 09:33:27 +0200

Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, Damien Le Moal <dlemoal@xxxxxxxxxx>, Niklas Cassel <cassel@xxxxxxxxxx>

In-reply-to: <20250403034520.59597-1-bsdhenrymartin@gmail.com>

References: <20250403034520.59597-1-bsdhenrymartin@gmail.com>

Ui-outboundreport: notjunk:1;M01:P0:xF30ZRSJXlI=;NYQzFuTKlmtshV9ccHiMBtvtyNg KFZXVaNxkuavLV0gydzsX7go/AYBD0vgaLceKJt3EzLo+xtNJkZ2sFBwmyrxy7QRMvSMF5yLK HoTZhRAaUjzSV1F4K2XmlsNNuJgPWPlCJIg5BXCjSKUx/hVNKSt5ReTxut91oIBJkBsahjL5U 53qFYaA7nKe2y12FfcmYbfmY/WoQq96cm1JKPiYR2MREsvz8vmrRDzSExMXipPKYaiUn34eoo h25x62rIZ3g3Y7QikYYuITsLumMo2RBmHQl9EY5SBVE7yHkaSPa9vyObEZpV99Xd+dI7BXVyS lb98thJalKPseKae1m3v1X0ZVqEm/XWJdDAHhuv+xQtaSWapLGX4hinah9l6BJ8XoAkT9CBJY G+taGF0uQkm9NTWec0k/urBg5cgLTcBfyzlDg9refbu60VgKp2k3NLtrDjp4JbZSc9rM4QOSE OWYcnHZSYjmWYnq47I9/tlW/WL6MFSO/ovurkHVrygXtGbBYh04e0c3iaocRiG0G0ZeLLxvkc 6N6dnmOeCL0M8XGvJYuKBjb7CA4sJQ7ETPVPNcMIWZdpXGEB99Fc7aK/XsdmjfnE9QAGntA/r NIveEFU+f0+sZqBPdlhyBLUj/6izF4wDXaOYv6IPy+D2mmIhkVf/6yD8laNTJPVZNbcuujR/s rI3oQ3hrK5zJqu8i8qVQ0hBdP/agtR5EgZ4Wci4QHEY2F1a/ZlTUJFs44U5c8wcDuYznZWsOI YI/RQt+D0Fl+h/V8CwMdUrIQVXh5jhJAe4197PbQBr5dpc+9S4iVaODoGfVy5LsUAbG17gh8A Q5eFeBfnDTZ07IUMRbK7T5R0o0jsQ7xWxkAbnl9KE1Y4SPK9ENZ+Q/0RbYoFtbDUDtpXTSEEB 1BzTIBWK6PTuGuU5kF8U28yTJCMST+xLAnuOeVLnmKL/SBmRgQ5k4f22dr74lboWOevAST9dO Yde+Hkk7xl7X2F3/YpDNK21HAdpfgyiNmD8HtqwslqHvF3kCeeFb1nBr18L2yeEcfYEL0CCeK L8ueEhv4Icl/mTBpFtFfeD4kU/+IDfN53jRh63Cn6oVdwotI2aZxil+LpqG/WULhW6Je4uVSd mtF0qhpeoi8uaRe+42KH3rel3v1MwFTnI7CzA2kEW2kfcET/mMFXQM2aa73xU2luEavdPgrk7 gc5tyV2eg6HvYNCI8G+6PWvdx98hnj6Ea64/wV2PuMpOLfWIScr88vG8U4o+zNGqiVm3AGTWI ZOA+MWhFg5ezn9izFvuMQg2Lm6YceSQoInAjX8NwM9t9k2McuVJpLkRJ5SQD4AesYlhPhPBO6 WNR3/Z1p9cks63q4hBmJ05FpgElHRpZaIDO8Rjb6Kt69+yHHF8ZSWTqwV8plx3FsxFDuI6LJq IFqF4UbBLiO1CZopU0OJTEmQBg8HwwgUWoJiLoBQkyjAZ2D4neYmzmiN5ASph6Ly6xR6/PVNY ia/95pUWSr4Lj2EInuKSfzypJHTqR37/abk3W8oJNH/HegR7V

User-agent: Mozilla Thunderbird

…
> Add NULL check after devm_ioremap() to prevent this issue.
Can a summary phrase like “Prevent null pointer dereference in pxa_ata_probe()”
be a bit nicer?
…
> +++ b/drivers/ata/pata_pxa.c
> @@ -223,11 +223,16 @@ static int pxa_ata_probe(struct platform_device *pdev)
>
> 	ap->ioaddr.cmd_addr	= devm_ioremap(&pdev->dev, cmd_res->start,
> 						resource_size(cmd_res));
> +	if (!ap->ioaddr.cmd_addr)
> +		return -ENOMEM;
Can a blank line be desirable after such a statement?
Regards,
Markus

(追記) (追記ここまで)