Re: [PATCH v2 3/3] sequencer: keep auto maintenance out of the commands a sequence spawns

• To: gitster@xxxxxxxxx
• Subject: Re: [PATCH v2 3/3] sequencer: keep auto maintenance out of the commands a sequence spawns
• From: Thomas Bachem <mail@xxxxxxxxxxxxxxxx>
• Date: Sat, 5 Sep 2026 07:42:02 +0200
• Cc: git@xxxxxxxxxxxxxxx, phillip.wood@xxxxxxxxxxxxx, ps@xxxxxx, johannes.schindelin@xxxxxx
• In-reply-to: <xmqqwlt03e6k.fsf@gitster.g>
• References: <pull.2217.git.1788508426.gitgitgadget@gmail.com> <pull.2217.v2.git.1788537086.gitgitgadget@gmail.com> <9a6fc0427a8bc7e7abcc0518214b1dafc2efaa6a.1788537086.git.gitgitgadget@gmail.com> <xmqqwlt03e6k.fsf@gitster.g>

Hi Junio,
On 04/09/2026 23:21, Junio C Hamano wrote:
> Does this have to be a "struct strbuf", not "const char *"? The
> latter makes it clear that it will never change its value once you
> built it in disable_auto_maintenance().
It doesn't. I'll make it a char * that replay_ctx_release() frees,
built the way you sketch, in the next version.
Thanks,
Thomas

• References:
  • [PATCH 0/2] sequencer: leave auto maintenance to the end of a rebase
    • From: Thomas Bachem via GitGitGadget
  • [PATCH v2 0/3] sequencer: leave auto maintenance to the end of a sequence
    • From: Thomas Bachem via GitGitGadget
  • [PATCH v2 3/3] sequencer: keep auto maintenance out of the commands a sequence spawns
    • From: Thomas Bachem via GitGitGadget
  • Re: [PATCH v2 3/3] sequencer: keep auto maintenance out of the commands a sequence spawns
    • From: Junio C Hamano

• Prev by Date: Re: [PATCH v3] rerere: keep a background gc from killing a rebase
• Next by Date: kh/doc-datamodel
• Previous by thread: Re: [PATCH v2 3/3] sequencer: keep auto maintenance out of the commands a sequence spawns
• Next by thread: [PATCH v2 1/3] config: add git_config_append_parameter()
• Index(es):
  • Date
  • Thread