Phillip Wood <phillip.wood123@xxxxxxxxx> writes: > What does pinning a test mean? > [...] > Using test_must_fail() here without checking the error message means > we don't verify the reason that the cherry-pick failed. Dropped the test, so the wording goes with it. "pin" was jargon, sorry. Your placement was the right one: the advice test is what tells us the pick stopped on a conflict, which the bare test_must_fail did not. But the clean-pick test at t3507:98 and the conflicting case share the !opts->no_commit guard, so the assertion had no coverage left to add. v2 is the doc change alone.