Re: [PATCH 4/4] worktree add: let worktree_basename() return string copy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]




Junio C Hamano <gitster@xxxxxxxxx> writes:
>>> So going back to the confusing part of the log message,
>>> 
>>> Remind ... to worktree_basename_dup(). Among the three callers
>>> of worktree_basename(), two immediately make copies of the
>>> returned string before using and freeing it, which makes for an
>>> easy conversion. Convert the other one from resetting ...
>>> 
>>> or something like that, perhaps?
>>
>> Yes.
>
> Thanks. We do not know if other parts of the series gets more
> serious reviews that necessitates an updated version, so in the
> meantime I'll reword what I have locally.
And nothing happened since then. As the topic was in a good shape
except for the confusing part of the log, which we amended in my
tree already, let's mark the topic for 'next'.

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

(追記) (追記ここまで)
Powered by Linux

AltStyle によって変換されたページ (->オリジナル) /