Re: [PATCH v2 3/6] gitk: show color preferences on the button instead of the label

• To: Johannes Sixt via GitGitGadget <gitgitgadget@xxxxxxxxx>, git@xxxxxxxxxxxxxxx
• Subject: Re: [PATCH v2 3/6] gitk: show color preferences on the button instead of the label
• From: Mark Levedahl <mlevedahl@xxxxxxxxx>
• Date: 2026年8月13日 13:00:53 -0400
• Cc: Johannes Sixt <j6t@xxxxxxxx>
• In-reply-to: <75202a52d7912e67f6b92662f5349127c26c70b7.1786540582.git.gitgitgadget@gmail.com>
• References: <pull.2194.git.1785998419.gitgitgadget@gmail.com> <pull.2194.v2.git.1786540582.gitgitgadget@gmail.com> <75202a52d7912e67f6b92662f5349127c26c70b7.1786540582.git.gitgitgadget@gmail.com>
• User-agent: Mozilla Thunderbird

On 8/12/26 9:16 AM, Johannes Sixt via GitGitGadget wrote:
> - label $page.$uielem -padx 40 -relief sunk
> - ttk::button $page.${uielem}btn -text $label \
> + ttk::label $page.$uielem -text $label
> + button $page.${uielem}btn -padx 40 -pady 0 -borderwidth 2 \
> -command [list choosecolor $colorvar $idx $page $title]
>
This does make the new buttons stand out much better. Good.
Mark

• References:
  • [PATCH 0/5] gitk: make color preferences visually more pleasing and better usable
    • From: Johannes Sixt via GitGitGadget
  • [PATCH v2 0/6] gitk: make color preferences visually more pleasing and better usable
    • From: Johannes Sixt via GitGitGadget
  • [PATCH v2 3/6] gitk: show color preferences on the button instead of the label
    • From: Johannes Sixt via GitGitGadget

• Prev by Date: [PATCH] t1401: test symbolic-ref exit codes on a non-symbolic ref
• Next by Date: [PATCH v3 0/4] completion: add support for 'git history'
• Previous by thread: [PATCH v2 3/6] gitk: show color preferences on the button instead of the label
• Next by thread: [PATCH v2 2/6] gitk: condense repetitive code around color buttons into foreach loops
• Index(es):
  • Date
  • Thread