Tracker is not comment.module-proof

Thanks for this patch! I would never have been able to track this down.

Applied the patch and all my previous tracker entries are now showing up. (tracker had been displaying multiple empty pages before)

+1

Thank you for your feedback. What version of drupal did you patch?

I created a patch against HEAD for this issue.
I think it would be quite a pity you can't use the tracker without the comment module...

I had applied the patch to a 4.7.4 site, I'll test against the latest 5.0 beta tonight.

The latest version of the patch applied cleanly and fixed the problem on an install of 5.0 beta2

Tracker entries are now displayed correctly when the comment module is disabled.

I don't know about that COALESCE in there. I think we should deal with any NULL values (if those aren't set to not null, I didn't look) on the PHP side and leave the SQL as simple as possible.

Dealing with the NULL values in PHP will be quite difficult. The sort order depends on the columns l.last_comment_timestamp, which can be NULL, and n.changed.

The COALESCE function is not quite common, but it is ANSI SQL. It returns the first Non-NULL field.

COALESCE is supported in:

MySQL : http://dev.mysql.com/doc/refman/4.1/en/comparison-operators.html
PostgreSQL : http://www.postgresql.org/docs/7.1/static/functions-conditional.html
SQLite : http://www.sqlite.org/lang_expr.html
DB2 : http://publib.boulder.ibm.com/infocenter/db2luw/v8/index.jsp?topic=/com....

As noted, COALESCE is also ANSI SQL standard.

Reviewed at TC Drupal Bug Hunt

We have re-rolled this patch against HEAD. We also modified the behavior for users with no access to "access comments" permission: When the comment module is not enabled, or the user does not have access, the "replies" column does not appear.

All of a sudden I tend to like those Drupal group bug hunts ;)
Thank you for reviewing. Your addition about comment access makes great sense!

BTW: COALESCE is also supported by MS SQL: http://msdn2.microsoft.com/en-us/library/ms190349.aspx#

I think this was fixed in another issue, either in whole or partially. Needs to be verified.

Not fixed yet. The original issue is still present in Drupal 5.0 RC1

to see the issue: disable the comment module & create a node. Your tracker page will not show any entries created while the comment module has been disabled (any tracker entries created while the comment module was enabled will still be displayed).

Enabling the content module again does now re-display the previously hidden tracker entries, but this is not a fix in my opinion.

The latest patch from comment #9 applied successfully against 5.0 RC1, and completely fixes the issue from my testing.

RTBC ?

@Steven: Are you reffering to #102353? As pointed out by ashtonium, the patch over there only solves this issue partially. The tracker is still disfunctional when the comment module is disabled.

I confirm the patch in #9 still works. Essentially, this patch makes the tracker independent from the node_comment_statistics table content. Additionally the patch hides the comments column in the tracker when not appropriate.

patching file modules/tracker/tracker.module
Hunk #1 FAILED at 78.
Hunk #2 FAILED at 119.
2 out of 2 hunks FAILED -- saving rejects to file modules/tracker/tracker.module.rej

I'm seeing this problem in Drupal 5.1.
Subscribing.

Considering the age of this issue with no responses and that D5 is unsupported, I am closing this issue.