In working on #336255: CCK datestamp fields totally broken and fields without timezone handling mostly broken I noticed that we're doing a LEFT JOIN for the reminder and autoclose SQL for CCK date* fields. Since we do a separate query for each node type, when we join on the appropriate {content_*} table for the start date, I'm pretty sure we can INNER instead of LEFT JOIN there, which would be better for DB performance. I'll test that after lunch and commit a change if all looks good.

Comments

dww’s picture

Comment #1

dww
we/he/they
commented
Status: Active » Needs review
StatusFileSize
new 341331_signup_inner_not_left.1.d6.patch 963 bytes
new 341331_signup_inner_not_left.1.d5.patch 2.32 KB

These work for me. Anyone else care to look while I go eat? ;)

dww’s picture

Comment #2

dww
we/he/they
commented
Status: Needs review » Fixed

Committed to HEAD and DRUPAL-5--2.

Comment #3

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.