Here's a D6 port for ImageAPI, to accompany the imagecache 2.0 port.

Comments

dopry’s picture

Comment #1

dopry commented

@eaton, can you figure out why your editor always does so many white space changes? ;) Cool hopefully I'll have use for this soon... I just finished some imagecache 1.x cleanups I've been meaning to get to. Now I'm sorta back into imageapi/imagecache 2.x territory...

drewish’s picture

Comment #2

drewish commented

just wanted to say that this has been working fine with GD for me.

messenger’s picture

Comment #3

messenger commented

I am getting fails when I apply this, what version of imageapi does this patch apply against?
I realize it's a dev version, but must have been one prior to the current one?
thanks.

drewish’s picture

Comment #4

drewish commented
StatusFileSize
new imageapi_232623.patch 22.58 KB

messenger, it's against HEAD.

Here's an update that fixes the menu access to be D6.2 compatible and incorporates the fixes I posted in: #246203: Several bug fixes for the commandline ImageMagick module .

drewish’s picture

Comment #5

drewish commented
StatusFileSize
new imageapi_232623.patch 21.95 KB

reviewing the last patch i realized that there have been some bug fixes in HEAD that didn't get applied to that patch... updating.

messenger’s picture

Comment #6

messenger commented

Thanks for this.
I grabbed the files from CVS.
I had one fail

patching file imageapi.module
Hunk #1 FAILED at 1.
1 out of 11 hunks FAILED -- saving rejects to file imageapi.module.rej
patching file imageapi_gd.info
patching file imageapi_gd.module
patching file imageapi_imagemagick.info
patching file imageapi_imagemagick.module
patching file imageapi_imagick.info
patching file imageapi_imagick.module

thanks again.

drewish’s picture

Comment #7

drewish commented
StatusFileSize
new imageapi_232623.patch 22.46 KB

i'm guessing it was the CVS Id at the top of the file. here's and updated patch give it a try, it's got some imageapi_imagemagick changes that i don't want to untangle right now (basically it queues up operations and only calls convert once when closing the image).

dopry’s picture

Comment #8

dopry commented
Status: Needs review » Needs work

I totally added everything but the 6.x menu update stuff to 5.x.... even the batch processing for imagemagick. so this will need to be re-rolled against head... and I think imageapi 1.x is feature complete now!! It's got all the goodies I want for it...

@drewish: thanks a lot for you help getting this stuff stabilized I owe you beer next time we get to hang out...

drewish’s picture

Comment #9

drewish commented
Status: Needs work » Needs review
StatusFileSize
new imageapi_232623.patch 15.63 KB

here's a re-roll, just gave it a very cursory testing.

psynaptic’s picture

Comment #10

psynaptic commented

I just did a checkout of HEAD and applied the re-rolled patch by drewish on #9 and it patched successfully. Thanks drewish!

When I installed it I got an error:

Call to undefined function imageapi_get_available_toolkits()

I refreshed the page and it went away.

Edit: Refreshing the page just reloaded the module page with the imageapi not enabled.

Edit 2: This was because I was enabling imagecache at the same time as imageapi. I enabled imageapi first, then a toolkit (GD2 in my case) and then imagecache and it worked fine.

drewish’s picture

Comment #11

drewish commented
StatusFileSize
new imageapi_232623.patch 13.95 KB

re-rolled patch.

drewish’s picture

Comment #12

drewish commented
StatusFileSize
new imageapi_232623.patch 17.86 KB

* removed the php version requirements check from imageapi.install file since that's in the .info file now.
* imageapi_uninstall now removes the variables.
* imageapi_default_toolkit() now checks if there is an imagetoolkit if the old default has been disabled. this fixes a problem with the menu if you don't enable the GD toolkit.
* renamed image_jpeg_quality to imageapi_jpeg_quality since it's really a separate setting.
* imageapi_imagemagick_convert was referencing WATCHDOG_ERRROR, changed that to WATCHDOG_ERROR.

dopry’s picture

Comment #13

dopry commented
Status: Needs review » Fixed

committed to HEAD... uh-oh.

eaton’s picture

Comment #14

eaton commented

WOO! Thanks, drewish and dww. This is awesome news. ;)

drewish’s picture

Comment #15

drewish commented

eaton, either you're in the wrong issue queue or you meant to say dopry ;)

eaton’s picture

Comment #16

eaton commented

You are in fact correct. This is the problem with having IRC open in one window and issues in another. Also, there are too many people whose names start with 'd'. ;-)

Seriously, though. Hooray! DOPRY. *grin*

messenger’s picture

Comment #17

messenger commented

I installed this without problems and it is working fine so far. Tend only to post when there's problems, but thought I'd let ya know I'm using it as is.

Anonymous’s picture

Comment #18

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.