Feature Proposals » saveFile function to be atomic -- writing completely or not writing at all

Summary

Detail

Edit Form

Motivation

TWiki::Store::RcsFile::saveFile() writes to a specified file naively. So a file may have a partially written content if saveFile() is interrupted after it starts writing but before it completes writing. saveFile() should be atomic -- writing completely or not writing at all.

Description and Documentation

Instead of writing naively, writing to a temporary file and then renaming to the specified name makes saveFile() atomic. More specifically, it will writie to a file name having ".PROCESS_ID" appended, and then it will rename to the specified file name.

Examples

Impact

Implementation

-- Contributors: Hideyo Imazu - 2016年11月10日

Discussion

Yes, indeed, good proposal.

-- Peter Thoeny - 2016年11月17日