Edit - Stack Overflow

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

Required fields*

Simple Counter Javascript

Today I'm working on making a simple counter with HTML / CSS and JS.

My javascript isn't working and I don't know why.. I read a lot on the internet and tried to add "async" but it seems that my code needs a review

let counter = document.getElementById('counter');
let increaseButton = document.getElementById('increase');
let decreaseButton = document.getElementById("decrease");
let resetButton = document.getElementById("reset");
let count = 0;
function functionIncrease() {
 count ++;
 counter.innerHTML(count);
 color();
}
function functionDecrease() {
 count--;
 counter.innerHTML(count);
 color();
}
function functionReset() {
 count = 0;
 counter.innerHTML(count);
 color();
}
function color() {
 if (count > 0) {
 counter.style.color = "green";
 } else if (count > 0) {
 counter.style.color = "red";
 }
}
increaseButton.addEventListener("click", functionIncrease());
decreaseButton.addEventListener("click", functionDecrease());
resetButton.addEventListener("click", functionReset())

<main>
 <h1>My Simple Counter</h1>
 <p id="counter">0</p>
 <div class="button">
 <button id="decrease">Decrease</button>
 <button id="reset">Reset</button>
 <button id="increase">Increase</button>
 </div>
</main>

I think it's just a stupid error, but I really need your help !

Thank you!

Answer*

let counterDisplayElem = document.querySelector('.counter-display');
 let counterMinusElem = document.querySelector('.counter-minus');
 let counterPlusElem = document.querySelector('.counter-plus');
 let reset=document.querySelector('.reset');
 let count = 0;

 updateDisplay();

 counterPlusElem.addEventListener("click",()=>{
 count++;
 updateDisplay();
 color();
 }) ;

 counterMinusElem.addEventListener("click",()=>{
 count--;
 updateDisplay();
 color();
 });

 reset.addEventListener("click",()=>{
 	count=0;
 updateDisplay();
 });

 function updateDisplay(){
 counterDisplayElem.innerHTML = count;
 };

 function color() {
 if (count > 0) {
 counterDisplayElem.style.color = "green";
 } else if (count < 0) {
 counterDisplayElem.style.color = "red";
 }
 }



 <h1 class="counter-display">(..)</h1>
 <button class="counter-minus">-</button>
 <button class="counter-plus">+</button>
 <button class="reset">Reset</button>

Draft saved

Draft discarded

Edit Summary*

Cancel

Your answer could be improved with additional supporting information. Please edit to add further details, such as citations or documentation, so that others can confirm that your answer is correct. You can find more information on how to write good answers in the help center.

Community
– Community Bot

2022年10月02日 02:46:49 +00:00
Commented Oct 2, 2022 at 2:46

Add a comment |

How to Edit

Correct minor typos or mistakes
Clarify meaning without changing it
Add related resources or links
Always respect the author’s intent
Don’t use edits to reply to the author

How to Format

create code fences with backticks ` or tildes ~
```
like so
```
add language identifier to highlight code
```python
def function(foo):
print(foo)
```
put returns between paragraphs
for linebreak add 2 spaces at end
_italic_ or **bold**
indent code by 4 spaces
backtick escapes `like _so_`
quote by placing > at start of line
to make links (use https whenever possible)

<https://example.com>

[example](https://example.com)

<a href="https://example.com">example</a>

formatting help »
answering help »

How to Tag

A tag is a keyword or label that categorizes your question with other, similar questions. Choose one or more (up to 5) tags that will help answerers to find and interpret your question.

complete the sentence: my question is about...
use tags that describe things or concepts that are essential, not incidental to your question
favor using existing popular tags
read the descriptions that appear below the tag

If your question is primarily about a topic for which you can't find a tag:

combine multiple words into single-words with hyphens (e.g. python-3.x), up to a maximum of 35 characters
creating new tags is a privilege; if you can't yet create a tag you need, then post this question without it, then ask the community to create it for you

popular tags »

default

CollectivesTM on Stack Overflow

Simple Counter Javascript

Answer*