Edit - Stack Overflow

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

Required fields*

Rev

Required fields*

Designing classes in python

I am designing a class which produces information like cpu usage,disk usage,Mem usage,...... for 3 systems,lets say data centers which has many workstations and work stations has many PCs.So the CPU usage and the other parameters are required for all the 3 levels(Datacenters, Workstations, Pcs). Please suggest is the below class design correct or how it is to be designed

EDIT

class Datacenters:
 def __init__(self,name,location,cpu,mem):
 self.name=name
 self.location=location
 self.cpu=cpu
 self.mem=mem
 def getparam(self):
 return self.name,self.location ,self.cpu,self.mem
 def getname(self):
 return self.name
class WS(Datacenters):
 def __init__(self,name,location,cpu,mem,obj):
 #datacentername = Datacenters.__init__(self) #To which data center it is associated
 obj.getname() #To which data center it is associated
 self.name=name
 self.location=location
 self.cpu=cpu
 self.mem=mem
def getparam(self,obj):
 return self.name,self.location ,self.cpu,self.mem,obj.getname()
def getpcname(self):
 return self.name
class Pcs(WS):
 def __init__(self,name,location,cpu,mem,obj):
 obj.getpcname() #To which WS it is associated
 self.name=name
 self.location=location
 self.cpu=cpu
 self.mem=mem
 def getparam(self,obj):
 return self.name,self.location ,self.cpu,self.mem,obj.getpcname()
a = Datacenters("dc1","Bl1",20,30)
print a.getparam()
b = WS("WS1","Bl1",20,30,a)
print b.getparam(a)
c = Pcs("PC1","Bl1",20,30,b)
print c.getparam(b)

Answer*

Much of your code is pointless. I removed the lines that isn't needed:

 class Datacenter:
 def __init__(self,name,location,cpu,mem):
 self.name=name
 self.location=location
 self.cpu=cpu
 self.mem=mem
 
 class Workstation:
 def __init__(self,name,location,cpu,mem,datacenter):
 self.name=name
 self.location=location
 self.cpu=cpu
 self.mem=mem
 self.datacenter=datacenter
 
 class Computer:
 def __init__(self,name,location,cpu,mem,workstation):
 # This line does nothing:
 self.name=name
 self.location=location
 self.cpu=cpu
 self.mem=mem
 self.workstation=workstation

You don't need to write accessor methods in Python. Just access the attributes directly.
Also, the line `obj.getname()` did nothing.

And of course, as pointed out by others here, since when does a Datacenter have a CPU? And doesn't a Computer have the same location as a Workstation? Then it doesn't need the location. Probably your code should look like this:

 class Datacenter:
 def __init__(self,name,location):
 self.name=name
 self.location=location
 
 class Workstation:
 def __init__(self,name,location,datacenter):
 self.name=name
 self.location=location
 self.datacenter=datacenter
 
 class Computer:
 def __init__(self,name,cpu,mem,workstation):
 # This line does nothing:
 self.name=name
 self.cpu=cpu
 self.mem=mem
 self.workstation=workstation

 def location(self):
 return self.workstation.location

 def datacenter(self):
 return self.workstation.datacenter

Draft saved

Draft discarded

Edit Summary*

Cancel

original class names doesn't make sense, they shouldn't be plural

Paweł Prażak
– Paweł Prażak

2010年12月19日 18:27:38 +00:00
Commented Dec 19, 2010 at 18:27
@Paweł Prażak: This is true as well, I'll update. WS is also a crappy name. :)

Lennart Regebro
– Lennart Regebro

2010年12月19日 18:51:32 +00:00
Commented Dec 19, 2010 at 18:51
Thanks this was elpful +1 for the explaination

Rajeev
– Rajeev

2010年12月20日 05:21:10 +00:00
Commented Dec 20, 2010 at 5:21

Add a comment |

How to Edit

Correct minor typos or mistakes
Clarify meaning without changing it
Add related resources or links
Always respect the author’s intent
Don’t use edits to reply to the author

How to Format

create code fences with backticks ` or tildes ~
```
like so
```
add language identifier to highlight code
```python
def function(foo):
print(foo)
```
put returns between paragraphs
for linebreak add 2 spaces at end
_italic_ or **bold**
indent code by 4 spaces
backtick escapes `like _so_`
quote by placing > at start of line
to make links (use https whenever possible)

<https://example.com>

[example](https://example.com)

<a href="https://example.com">example</a>

formatting help »
answering help »

How to Tag

A tag is a keyword or label that categorizes your question with other, similar questions. Choose one or more (up to 5) tags that will help answerers to find and interpret your question.

complete the sentence: my question is about...
use tags that describe things or concepts that are essential, not incidental to your question
favor using existing popular tags
read the descriptions that appear below the tag

If your question is primarily about a topic for which you can't find a tag:

combine multiple words into single-words with hyphens (e.g. python-3.x), up to a maximum of 35 characters
creating new tags is a privilege; if you can't yet create a tag you need, then post this question without it, then ask the community to create it for you

popular tags »

lang-py

CollectivesTM on Stack Overflow

Designing classes in python

Answer*