[patch] default homedir (was: Re: Problem withssh-keygen.exe.

Thu Dec 7 07:17:00 GMT 2000

At 11:32 12/7/00 +0100, Corinna Vinschen wrote:
>Personally I like if (!strlen (foo)) much more.

the only reason I don't code that way is that this treats
an integer as a boolean. it is, imho, sloppy code.
>I have applied your patch but I have changed this and that:

thanks.
>- You have used `passed_home_path' uninitialized which resulted in
> garbage in the output on my system when the `-p' option wasn't
> given.

that was at line 393, the original strcpy, right? I thought
strcpy would effectively initialize it for us?
>- We are following the GNU coding convention in that a space should be

opps, another habit, again mental note made for future patches...
this particular file isn't exactly the model of consistent
formatting though, is it?
>- I have changed the `if (strlen (foo) == 0) conditionals to
> `if (foo[0] == '0円')' which I personally prefer when checking
> for len == 0.

true, can be faster, but relies on implementation knowledge,
from a pure software engineering approach this is dangerous;
but then the odds that "strings" will ever be changed away
from null terminated char arrays is what, about 0.0? ;)
>While incorporating your patch I found a typo in the longopts
>structure. I had once written "loca-group" instead of "local-group".
>I have fixed this in the same go.

amazing what you find occasionally isn't it.
>Thanks for contributing that patch,

no problem, I was part of the affected group, as were
people I know... don't ya just love open source. :)
now the forces of openness
 have a powerful and
 unexpected new ally
 http://ibm.com/linux/
--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe@sourceware.cygnus.com