[Moving to the devel list.] Here's a patch for font_manager.py to close opened files. Could somebody review the patch? As I mentioned earlier, I don't understand why cPickle/pickle is not imported at the top level, so I'm hesitant to check this in without review.
"Edin Salkovic" <edi...@gm...> writes: > I would just suggest using open() instead of file(), but this is a > general Python tip :) > > Everything else seems OK. Thanks, committed. -- Jouni K. Seppänen http://www.iki.fi/jks
SSB3b3VsZCBqdXN0IHN1Z2dlc3QgdXNpbmcgb3BlbigpIGluc3RlYWQgb2YgZmlsZSgpLCBidXQg dGhpcyBpcyBhCmdlbmVyYWwgUHl0aG9uIHRpcCA6KQoKRXZlcnl0aGluZyBlbHNlIHNlZW1zIE9L LgoKQmVzdCwKRWRpbgoKT24gMy8xMy8wNywgSm91bmkgSy4gU2VwcMOkbmVuIDxqa3NAaWtpLmZp PiB3cm90ZToKPiBbTW92aW5nIHRvIHRoZSBkZXZlbCBsaXN0Ll0KPgo+IEhlcmUncyBhIHBhdGNo IGZvciBmb250X21hbmFnZXIucHkgdG8gY2xvc2Ugb3BlbmVkIGZpbGVzLiBDb3VsZAo+IHNvbWVi b2R5IHJldmlldyB0aGUgcGF0Y2g/IEFzIEkgbWVudGlvbmVkIGVhcmxpZXIsIEkgZG9uJ3QgdW5k ZXJzdGFuZAo+IHdoeSBjUGlja2xlL3BpY2tsZSBpcyBub3QgaW1wb3J0ZWQgYXQgdGhlIHRvcCBs ZXZlbCwgc28gSSdtIGhlc2l0YW50Cj4gdG8gY2hlY2sgdGhpcyBpbiB3aXRob3V0IHJldmlldy4K Pgo+Cj4KPiBKb3VuaSBLLiBTZXBww6RuZW4gPGprc0Bpa2kuZmk+IHdyaXRlczoKPgo+ID4gSSBm aXhlZCBhbm90aGVyIGZpbGVoYW5kbGUgbGVhayBpbiB0aGUgcGRmIGJhY2tlbmQsIHNvIGhlcmUn cyBhIG1vcmUKPiA+IGNvbXBsZXRlIHBhdGNoLiBUaGVyZSBhcmUgYWxzbyBzZXZlcmFsIGNhc2Vz IG9mIGZpbGUoLi4uKSBiZWluZyBwYXNzZWQKPiA+IHRvIHBpY2tsZS5kdW1wIG9yIHBpY2tsZS5s b2FkIGluIGZvbnRfbWFuYWdlci5weS4gSSB3YXMgZ29pbmcgdG8gdGFrZQo+ID4gY2FyZSBvZiB0 aGVzZSBieSB3cml0aW5nIHNvbWUgdXRpbGl0eSBmdW5jdGlvbnMsIGJ1dCBJIHN0YXJ0ZWQKPiA+ IHdvbmRlcmluZyB3aHkgdGhlIGltcG9ydCBvZiBjUGlja2xlIG9yIHBpY2tsZSBpcyBkb25lIG9u bHkgd2l0aGluCj4gPiBtZXRob2RzIG9mIEZvbnRNYW5hZ2VyIGFuZCBub3QgYXQgdGhlIHRvcCBs ZXZlbC4gQXJlIHRoZXJlIHNvbWUKPiA+IHBsYXRmb3JtcyB3aGVyZSBuZWl0aGVyIGlzIGF2YWls YWJsZSwgb3Igd2hhdCBpcyB0aGUgcmF0aW9uYWxlPwo+Cj4gLS0KPiBKb3VuaSBLLiBTZXBww6Ru ZW4KPiBodHRwOi8vd3d3LmlraS5maS9qa3MKPgo+IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiBUYWtlIFN1 cnZleXMuIEVhcm4gQ2FzaC4gSW5mbHVlbmNlIHRoZSBGdXR1cmUgb2YgSVQKPiBKb2luIFNvdXJj ZUZvcmdlLm5ldCdzIFRlY2hzYXkgcGFuZWwgYW5kIHlvdSdsbCBnZXQgdGhlIGNoYW5jZSB0byBz aGFyZSB5b3VyCj4gb3BpbmlvbnMgb24gSVQgJiBidXNpbmVzcyB0b3BpY3MgdGhyb3VnaCBicmll ZiBzdXJ2ZXlzLWFuZCBlYXJuIGNhc2gKPiBodHRwOi8vd3d3LnRlY2hzYXkuY29tL2RlZmF1bHQu cGhwP3BhZ2U9am9pbi5waHAmcD1zb3VyY2Vmb3JnZSZDSUQ9REVWREVWCj4gX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBNYXRwbG90bGliLWRldmVsIG1h aWxpbmcgbGlzdAo+IE1hdHBsb3RsaWItZGV2ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0Cj4gaHR0 cHM6Ly9saXN0cy5zb3VyY2Vmb3JnZS5uZXQvbGlzdHMvbGlzdGluZm8vbWF0cGxvdGxpYi1kZXZl bAo+Cj4KPgo=