Hi All, As part of nipy[1] we have a spectral colormap which we use and would like to include it upstream as part of matplotlib. I'm working on a patch but before I submit it, I need some advice on how boilerplate.py should be used. I've made the required additions to _cm.py, pylab.py and boilerplate.py and when I run boilerplate.py it generates a spectral() function as it does for all the other colormaps. My question is, how should the output of boilerplate.py be included into pylab.py? Should I just cut and paste the output, or is there some automagic tool for doing it? Cheers, Tim Leslie [1] http://neuroimaging.scipy.org/
>>>>> "Tim" == Tim Leslie <tim...@gm...> writes: Tim> colormaps. My question is, how should the output of Tim> boilerplate.py be included into pylab.py? Should I just cut Tim> and paste the output, or is there some automagic tool for Tim> doing it? Yep, just cut the stuff below ### Do not edit below this point and paste in the boilerplate output. JDH
On 12/20/06, John Hunter <jdh...@ac...> wrote: > >>>>> "Tim" == Tim Leslie <tim...@gm...> writes: > Tim> colormaps. My question is, how should the output of > Tim> boilerplate.py be included into pylab.py? Should I just cut > Tim> and paste the output, or is there some automagic tool for > Tim> doing it? > > Yep, just cut the stuff below > > ### Do not edit below this point > > and paste in the boilerplate output. Thanks, that all seems to have worked fine. I've attached the patch with this email. John, I was wondering if I have svn write access. I seem to recall I had it a year or two ago, but I can't find any evidence to back this up, so maybe I'm mistaken. Could you check for me? Cheers, Tim > > JDH >
>>>>> "Tim" == Tim Leslie <tim...@gm...> writes: Tim> John, I was wondering if I have svn write access. I seem to Tim> recall I had it a year or two ago, but I can't find any Tim> evidence to back this up, so maybe I'm mistaken. Could you Tim> check for me? I don't see you on the devel list. A few months ago I purged everyone who had not made a commit in a year or so and maybe you were removed then (and posted here to this effect). In general, I don't mind adding people and certainly welcome the relief of not having to manage patches, but the devel list had grown to long. Why don't we manage this submission through the existing devels, and if the patches become fast and furious, I'm more than happy to (re)add you. If your patch doesn't make it in within 48 hours please post here with a complaint. JKDH
>>>>> "John" == John Hunter <jdh...@ac...> writes: John> If your patch doesn't make it in within 48 hours please post John> here with a complaint. OK, I committed it. In addition to the files you modified, you should consider CHANGELOG and API_CHANGES. The former for non-trivial commits, the latter for API_CHANGES. With this commit, I made an entry to CHANGELOG. Many thanks, JDH