While investigating the imshow problem reported today by Emanuale Passera (a problem that seems to have been fixed, though I don't know when or how), I stumbled across the verbose-helpful report of the "units" rcParams entry. Sure enough, it is in rcsetup.py and in matplotlibrc.template, but a quick code scan turned up no evidence that it is used anywhere. Is it vestigial, and a candidate for surgical removal? Eric
On Tue, Apr 19, 2011 at 3:07 AM, Eric Firing <ef...@ha...> wrote: > While investigating the imshow problem reported today by Emanuale > Passera (a problem that seems to have been fixed, though I don't know > when or how), I stumbled across the verbose-helpful report of the > "units" rcParams entry. Sure enough, it is in rcsetup.py and in > matplotlibrc.template, but a quick code scan turned up no evidence that > it is used anywhere. Is it vestigial, and a candidate for surgical removal? James, do you know what the units rc parameter was for, and can it be removed? Darren
Honestly, I do not know what the units rc param is for. Personally I try to stay away from anything rc parameter related. I would guess that it was put in to handle default units, but the unit system handles defaults based on the type of data being plotted. Perhaps it was added in the first draft of the unit code and never removed when it was revised? As far as I know, there is no need for it. --James > -----Original Message----- > From: Darren Dale [mailto:dsd...@gm...] > Sent: Tuesday, April 19, 2011 4:42 AM > To: Eric Firing; jre...@ea... > Cc: matplotlib development list > Subject: Re: [matplotlib-devel] What is rcParams['units'] for? > > On Tue, Apr 19, 2011 at 3:07 AM, Eric Firing <ef...@ha...> wrote: > > While investigating the imshow problem reported today by Emanuale > > Passera (a problem that seems to have been fixed, though I don't know > > when or how), I stumbled across the verbose-helpful report of the > > "units" rcParams entry. Sure enough, it is in rcsetup.py and in > > matplotlibrc.template, but a quick code scan turned up no evidence > > that it is used anywhere. Is it vestigial, and a candidate for surgical > removal? > > James, do you know what the units rc parameter was for, and can it be > removed? > > Darren > > ------------------------------------------------------------------------------ > Benefiting from Server Virtualization: Beyond Initial Workload Consolidation - > - Increasing the use of server virtualization is a top priority.Virtualization can > reduce costs, simplify management, and improve application availability and > disaster protection. Learn more about boosting the value of server > virtualization. http://p.sf.net/sfu/vmware-sfdev2dev > _______________________________________________ > Matplotlib-devel mailing list > Mat...@li... > https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
On Tue, Apr 19, 2011 at 10:03 AM, James Evans <jre...@ea...> wrote: > Honestly, I do not know what the units rc param is for. Personally I try to stay away from anything rc parameter related. > > I would guess that it was put in to handle default units, but the unit system handles defaults based on the type of data being plotted. Perhaps it was added in the first draft of the unit code and never removed when it was revised? > > As far as I know, there is no need for it. Unfortunately, I can't recall what it was added for either. As Eric notes, it doesn't even make it into matplotlibrc.template, which usually has a definition of the param, and I can't find it used anywhere in the code base either. JDH
On 04/19/2011 05:03 AM, James Evans wrote: > Honestly, I do not know what the units rc param is for. Personally I try to stay away from anything rc parameter related. > I'm not an rc fan, either, though the rc system does have its benefits. > I would guess that it was put in to handle default units, but the unit system handles defaults based on the type of data being plotted. Perhaps it was added in the first draft of the unit code and never removed when it was revised? > It's a boolean. I suspect that long ago it was for turning experimental units support on or off. > As far as I know, there is no need for it. I will try removing it. Eric > > --James > > >> -----Original Message----- >> From: Darren Dale [mailto:dsd...@gm...] >> Sent: Tuesday, April 19, 2011 4:42 AM >> To: Eric Firing; jre...@ea... >> Cc: matplotlib development list >> Subject: Re: [matplotlib-devel] What is rcParams['units'] for? >> >> On Tue, Apr 19, 2011 at 3:07 AM, Eric Firing<ef...@ha...> wrote: >>> While investigating the imshow problem reported today by Emanuale >>> Passera (a problem that seems to have been fixed, though I don't know >>> when or how), I stumbled across the verbose-helpful report of the >>> "units" rcParams entry. Sure enough, it is in rcsetup.py and in >>> matplotlibrc.template, but a quick code scan turned up no evidence >>> that it is used anywhere. Is it vestigial, and a candidate for surgical >> removal? >> >> James, do you know what the units rc parameter was for, and can it be >> removed? >> >> Darren >> >> ------------------------------------------------------------------------------ >> Benefiting from Server Virtualization: Beyond Initial Workload Consolidation - >> - Increasing the use of server virtualization is a top priority.Virtualization can >> reduce costs, simplify management, and improve application availability and >> disaster protection. Learn more about boosting the value of server >> virtualization. http://p.sf.net/sfu/vmware-sfdev2dev >> _______________________________________________ >> Matplotlib-devel mailing list >> Mat...@li... >> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel >