Edit - Software Engineering Stack Exchange

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

Required fields*

Rev

Title*

Body*

I see code like this sometimes (mixed PHP and JS in this case, but could be any server-side language):


 <script>
 var data = <?php echo $bigDataStructure ?>;
 // then lots more pure js with no php mixed in which can access the data variable
 </script>


Which seems like an appropriate way to pass data from a server-side scripting language to the JS that will run on the client (*ignoring the fact that a global var named `data` is itself an eye-watering notion*).

But I also sometimes see code like this (mixed JS and ColdFusion in this case):

 <script>
 if ($('#firstName').val() === <cfoutput>#query.firstName != "" ? query.firstName : query.nickName#</cfoutput>) {
 <cfif userHasPermission>
 $('#userForm').validate();
 <cfelse>
 $('#readOnlyNotice').show();
 disableForm();
 <cfif settings.auditEnabled>
 recordAccessAjax();
 </cfif>
 </cfif>
 }
 </script>

where the actual final version of the JS logic is dynamic. This, to me, feels like we're nearing the bog of eternal stench. Red flags galore. I could see (and have seen) this willy-nilly mixing get out of hand and create maintenance issues and debugging headaches.

What I'm wondering is whether there's a specific design pattern this violates? Or are there specific arguments that could be made against such dynamic code that I could present as reasons for moving away from the practice?

Note: [another question][1] asks whether it's a bad practice. Here, I assume that it is a bad practice and am looking for specific reasons why. The answers on the other question mainly focused on answering "is it bad?" and added suggestions of other ways to code the OP's example. 


 [1]: https://softwareengineering.stackexchange.com/questions/126671/is-it-considered-bad-practice-to-have-php-in-your-javascript

Draft saved

Draft discarded