Make statsd sample rate behave better.

Code Issues Proposed changes

As Dieter pointed out in bug 1090495
(https://bugs.launchpad.net/swift/+bug/1090495), the volume of metrics
can vary wildly between StatsD metrics.
This patch implements a partial solution by reducing the sample_rate
used for known high-volume metrics (operational experience will need to
inform this over time) and introducing a new tunable,
log_statsd_sample_rate_factor which is multiplied by the sample_rate for
every statsd stat. This tunable can be used to reduce StatsD traffic
proportionally for all metrics and is intended to replace
log_statsd_default_sample_rate, which is left alone for
backward-compatibility, should anyone be using it.
This patch also includes a drive-by fix for log_udp_port which wasn't
being converted to an int (I didn't verify that actually causes trouble
in SysLogHandler(), but it's definitely an improvement regardles).
Change-Id: Id404636e3629f6431cf1c4e64a143959750a3c23

This commit is contained in:

Darrell Bishop

2013年01月19日 15:25:27 -08:00

parent 6c5fc3ca00

commit 8801b74090

12 changed files with 183 additions and 55 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

3
etc/account-server.conf-sample

View File

@@ -24,7 +24,8 @@

# You can enable StatsD logging here:

# log_statsd_host = localhost

# log_statsd_port = 8125

# log_statsd_default_sample_rate = 1

# log_statsd_default_sample_rate = 1.0

# log_statsd_sample_rate_factor = 1.0

# log_statsd_metric_prefix =

# If you don't mind the extra disk space usage in overhead, you can turn this

# on to preallocate disk space with SQLite databases to decrease fragmentation.

Make statsd sample rate behave better.

3 etc/account-server.conf-sample Unescape Escape View File

3
etc/account-server.conf-sample

View File