tests: Keep port number in valid range

Code Issues Proposed changes

Previously (at least on OSX) this could lead to errors like
 socket.gaierror: [Errno 8] nodename nor servname provided, or not known
when we actually went and tried to connect to send the update (!!)
Change-Id: I86f6e731d1ee273c6772974ce597ac91be3937be

This commit is contained in:

Tim Burke

2025年05月22日 11:28:15 -07:00

parent f64269b981

commit 3ff6b34a3b

1 changed files with 5 additions and 5 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

10
test/unit/obj/test_updater.py

View File

@@ -90,19 +90,19 @@ class TestObjectUpdater(unittest.TestCase):

'replication_ip': '127.0.0.1',

# replication_port may be overridden in tests but

# include here for completeness...

'replication_port': 67890,

'replication_port': 60789,

'device': 'sda1', 'zone': 0},

{'id': 1, 'ip': '127.0.0.2', 'port': 1,

'replication_ip': '127.0.0.1',

'replication_port': 67890,

'replication_port': 60789,

'device': 'sda1', 'zone': 2},

{'id': 2, 'ip': '127.0.0.2', 'port': 1,

'replication_ip': '127.0.0.1',

'replication_port': 67890,

'replication_port': 60789,

'device': 'sda1', 'zone': 4},

{'id': 3, 'ip': '127.0.0.2', 'port': 1,

'replication_ip': '127.0.0.1',

'replication_port': 67890,

'replication_port': 60789,

'device': 'sda1', 'zone': 6}], 30),

f)

self.devices_dir = os.path.join(self.testdir, 'devices')

@@ -750,7 +750,7 @@ class TestObjectUpdater(unittest.TestCase):

{'failures': 1, 'outdated_unlinks': 1})

self.assertIsNone(pickle.load(open(op_path, 'rb')).get('successes'))

self.assertEqual(

['ERROR with remote server 127.0.0.1:67890/sda1: '

['ERROR with remote server 127.0.0.1:60789/sda1: '

'Connection refused'] * 3,

ou.logger.get_lines_for_level('error'))

self.assertEqual(

tests: Keep port number in valid range

10 test/unit/obj/test_updater.py Unescape Escape View File

10
test/unit/obj/test_updater.py

View File