Middleware that allows a user to have quoted Etags

Code Issues Proposed changes

Users have complained for a while that Swift's ETags don't match the
expected RFC formats. We've resisted fixing this for just as long,
worrying that the fix would break innumerable clients that expect the
value to be a hex-encoded MD5 digest and *nothing else*.
But, users keep asking for it, and some consumers (including some CDNs)
break if we *don't* have quoted etags -- so, let's make it an option.
With this middleware, Swift users can set metadata per-account or even
per-container to explicitly request RFC compliant etags or not. Swift
operators also get an option to change the default behavior
cluster-wide; it defaults to the old, non-compliant format.
See also:
 - https://tools.ietf.org/html/rfc2616#section-3.11
 - https://tools.ietf.org/html/rfc7232#section-2.3
Closes-Bug: 1099087
Closes-Bug: 1424614
Co-Authored-By: Tim Burke <tim.burke@gmail.com>
Change-Id: I380c6e34949d857158e11eb428b3eda9975d855d

This commit is contained in:

Romain LE DISEZ

2019年12月19日 14:24:51 -05:00

committed by Tim Burke

parent 742835a6ec

commit 27fd97cef9

7 changed files with 417 additions and 0 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

11
etc/proxy-server.conf-sample

View File

@@ -850,6 +850,17 @@ use = egg:swift#name_check

# maximum_length = 255

# forbidden_regexp = /\./|/\.\./|/\.$|/\.\.$

# Note: Etag quoter should be placed just after cache in the pipeline.

[filter:etag-quoter]

use = egg:swift#etag_quoter

# Historically, Swift has emitted bare MD5 hex digests as ETags, which is not

# RFC compliant. With this middleware in the pipeline, users can opt-in to

# RFC-compliant ETags on a per-account or per-container basis.

#

# Set to true to enable RFC-compliant ETags cluster-wide by default. Users

# can still opt-out by setting appropriate account or container metadata.

# enable_by_default = false

[filter:list-endpoints]

use = egg:swift#list_endpoints

# list_endpoints_path = /endpoints/

Middleware that allows a user to have quoted Etags

11 etc/proxy-server.conf-sample Unescape Escape View File

11
etc/proxy-server.conf-sample

View File